Type RemoteDevice fields and unify UPnP HTTP handling - #9
Merged
Conversation
Replace RemoteDevice's Map<String, Any> details bag with typed locationUrl and services fields (ServiceInfo promoted to a top-level class), so service URL resolution and TV detection read typed values instead of unchecked casts. Route device description GETs and SOAP POSTs through a shared UpnpHttp executor for consistent timeouts, headers and connection handling. No public API change. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RemoteDevice:details: Map<String, Any>removed; devices now carrylocationUrlandservices: List<ServiceInfo>directly (ServiceInfopromoted fromDeviceDescriptionParserto a top-level class).buildServiceUrl, cast service checks and TV detection use typed fields instead of unchecked castsUpnpHttp: device description retrieval (GET, 3-attempt linear backoff preserved) and SOAP control requests (POST) share one internal executor with consistent timeouts, User-Agent and connection cleanupTest plan
./gradlew test lint assembleReleasepasses locally (69/69 tests)