Conversation
New package.json
yjlou
left a comment
There was a problem hiding this comment.
Hey Tal,
Thanks for contributing to this repo. I am a new learner for nodejs. Do you mind explaining to me a little bit about what the difference in node and nodejs and why you think node is better than nodejs in this case?
If you don't mind, could you also add few more context in the commit log why package.json is required here?
For the input/output.json files, no worries about it. I will update them periodically (once a day for now). Let me know if you think more frequently is better.
Thanks in advance.
|
Hi @talbenbasat, Thanks for creating the pull request. Can you remove the "update data" part from the pull request, and left the "adding package.json" and "use node instead of nodejs" parts? @yjlou Regarding node vs nodejs, if you download and install nodejs from offical site, the default exported binaries are "node", "npm" and "npx". So I also agree with using "node" instead of "nodejs". |
Add package.json
Updated Israel data