Skip to content

Prevent Yjs unobserve warnings when destroy() runs after observers re… #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rahulCoder9417 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent Yjs unobserve warnings when destroy() runs after observers re… #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions src/y-monaco.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,14 +209,27 @@ export class MonacoBinding {
this.awareness = awareness
}
}
/**
* Destroy the MonacoBinding and clean up all listeners.
*
* @param {boolean} [skipYjsUnobserve=false] - When true, skips calling `ytext.unobserve`
* to avoid harmless Yjs warnings like:
* `[yjs] Tried to remove event handler that doesn't exist.`
*/
destroy ( skipYjsUnobserve = false) {
// skipYjsUnobserve will skip Yjs unobserve cause it can through error if y-text is already unobserved
this._monacoChangeHandler.dispose()
this._monacoDisposeHandler.dispose()

destroy () {
this._monacoChangeHandler.dispose()
this._monacoDisposeHandler.dispose()
this.ytext.unobserve(this._ytextObserver)
this.doc.off('beforeAllTransactions', this._beforeTransaction)
if (this.awareness) {
this.awareness.off('change', this._rerenderDecorations)
}
// optionally skip this part to avoid Yjs warning
if (!skipYjsUnobserve) {
try { this.ytext.unobserve(this._ytextObserver) } catch {}
}

this.doc.off('beforeAllTransactions', this._beforeTransaction)

if (this.awareness) {
this.awareness.off('change', this._rerenderDecorations)
}
}
}