fix: remove random number in cursor selection builder#148
Open
baotpham wants to merge 1 commit intoyjs:masterfrom
Open
fix: remove random number in cursor selection builder#148baotpham wants to merge 1 commit intoyjs:masterfrom
baotpham wants to merge 1 commit intoyjs:masterfrom
Conversation
|
I don't understand why we need to add 70 |
|
This is to make sure that the Alpha Channel of the Color is set to 70% opacity. Hence, when selecting the text, it overlays and does not hide the content below it. However, it only supports Hex Color as you can see in the code, and PR #154 fixes this for HSLA/RGB color codes So @baotpham @icode it may seem like a "random" number, but it is not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this causes selection color not rendering properly