fix: compare mark names in equalYTextPText#198
Closed
aonnikov wants to merge 1 commit intoyjs:masterfrom
Closed
Conversation
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
Author
|
Hey @dmonad , could you please look into this PR when you have a chance? |
|
@dmonad Why have you closed it? Will it be fixed in another PR? |
Member
|
We are working on a full rewrite. Thank you for the PR @aonnikov ! But I simply don't have the time to review all PRs & issues for the previous release before we move on. I hope you understand. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #197
When comparing text nodes
equalYTextPTextused to compare number of marks and their attributes, but not names. This did not work properly for marks without attributes. When changed one mark without attributes to mark with different type without attributes, the function result was negative.Accompanied the fix with unit test that demonstrates the issue.