Skip to content

fix: skip unnecessary sync on focus/selection changes #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kuanglijun312 wants to merge 1 commit into from
Closed

fix: skip unnecessary sync on focus/selection changes #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions src/plugins/sync-plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,19 +195,24 @@ export const ySyncPlugin = (yXmlFragment, {
}
onFirstRender()
return {
update: () => {
update: (view, prevState) => {
const pluginState = plugin.getState(view.state)
if (
pluginState.snapshot == null && pluginState.prevSnapshot == null
) {
// Check if document actually changed to skip unnecessary syncs from focus/selection changes
const docChanged = !prevState || !view.state.doc.eq(prevState.doc)

if (
// If the content doesn't change initially, we don't render anything to Yjs
// If the content was cleared by a user action, we want to catch the change and
// represent it in Yjs
initialContentChanged ||
view.state.doc.content.findDiffStart(
view.state.doc.type.createAndFill().content
) !== null
docChanged && (
// If the content doesn't change initially, we don't render anything to Yjs
// If the content was cleared by a user action, we want to catch the change and
// represent it in Yjs
initialContentChanged ||
view.state.doc.content.findDiffStart(
view.state.doc.type.createAndFill().content
) !== null
)
) {
initialContentChanged = true
if (
Expand Down