Expose the mapping when converting Prosemirror (JSON) to Y.Doc instances#69
Open
ankon wants to merge 1 commit intoyjs:masterfrom
Open
Expose the mapping when converting Prosemirror (JSON) to Y.Doc instances#69ankon wants to merge 1 commit intoyjs:masterfrom
mapping when converting Prosemirror (JSON) to Y.Doc instances#69ankon wants to merge 1 commit intoyjs:masterfrom
Conversation
…ances This mapping is needed for invoking the position transformation functions, and therefore shouldn't be thrown away.
|
Same here! Bump |
|
Any update on this one? |
|
Bumping this! @dmonad Any thoughts? |
Contributor
Author
|
Purely for the record: I no longer work with prosemirror at all, so if you want to merge this -- please do! But if it needs fixes/adjustments, please also feel absolutely free to do them as I won't be able to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mapping is needed for invoking the position transformation functions, and therefore
shouldn't be thrown away.
I added the parameter at the end and made it optional with a default matching the previous behavior, so I claim that this should be quite safe.
Possibly related:
yDocToProsemirrorJSONtoY.XmlTextandY.XmlElement#64 seems to be focused on the other direction to be more reusable, and may trigger a major version update -- so changing the order of the parameters here could also be done as part of that.