Skip to content

Conversation

@brunodevel
Copy link
Contributor

Changes In Code

Implicitly nullable parameters are deprecated in PHP 8.4.

In this pull request, I am explicitly declaring the $handler parameter as nullable to avoid deprecation warnings.

Issue ticket number / Business Case

The current implementation throws a deprecation warning every time a feature is checked in PHP 8.4 codebases.

Checklist before requesting a review

  • I have written PHPUnit tests.
  • I have updated the documentation and opened a pull request within
    the feature flags documentation repo.
  • I have checked code styles, PHPStan etc. pass.
  • I have provided an issue/business case.
  • I have added the enhancement label for a new feature.

@brunodevel brunodevel requested a review from peterfox as a code owner May 9, 2025 12:49
@brunodevel brunodevel changed the title Fix deprecated implicit nullable parameters Fix deprecated implicit nullable parameter May 9, 2025
@peterfox peterfox merged commit 33bb067 into ylsideas:main May 11, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants