Skip to content

Conversation

@bradymholt
Copy link
Member

  • New PUT and DELETE (update and delete) endpoints for scheduled_transactions.
  • payee_name and category_name fields have been added to subtransactions objects in scheduled transaction responses.
  • The goal_target amount for a category can now be updated.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bradymholt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request updates the YNAB API client to version 1.74.0. It introduces new PUT and DELETE endpoints for scheduled transactions, adds payee_name and category_name fields to subtransaction objects in scheduled transaction responses, and allows updating the goal_target amount for a category. The changes include modifications to the open API specification, generated models, API endpoints, and documentation.

Highlights

  • Scheduled Transactions: Added PUT and DELETE endpoints to the ScheduledTransactionsApi, enabling update and delete operations for scheduled transactions.
  • Subtransaction Objects: Included payee_name and category_name fields in ScheduledSubTransaction objects within scheduled transaction responses.
  • Category Goals: Enabled updating the goal_target amount for a category through the SaveCategory model.
  • API Version Update: The core API definition has been updated from version 1.72.1 to 1.74.0.

Changelog

Click here to see the changelog
  • .openapi-generator/FILES
    • Added PutScheduledTransactionWrapper.md to the list of generated documentation files.
    • Added test/test_put_scheduled_transaction_wrapper.py to the list of generated test files.
    • Added put_scheduled_transaction_wrapper.py to the list of generated model files.
  • .openapi-generator/VERSION
    • Updated the OpenAPI generator version from 7.10.0 to 7.12.0.
  • docs/PutScheduledTransactionWrapper.md
    • Created a new documentation file for the PutScheduledTransactionWrapper model.
  • docs/SaveCategory.md
    • Added goal_target to the properties of the SaveCategory model.
  • docs/ScheduledSubTransaction.md
    • Added payee_name and category_name to the properties of the ScheduledSubTransaction model.
  • docs/ScheduledTransactionsApi.md
    • Added documentation for the delete_scheduled_transaction and update_scheduled_transaction endpoints.
  • docs/TransactionsApi.md
    • Minor text change: Corrected a typo in the description of the import transactions endpoint, changing ""Import"" to "Import".
  • open_api_spec.yaml
    • Updated the API version to 1.74.0.
    • Added PUT and DELETE paths for scheduled transactions.
    • Added goal_target property to the SaveCategory schema.
    • Added payee_name and category_name properties to the ScheduledSubTransaction schema.
    • Added PutScheduledTransactionWrapper schema.
  • openapi-generator-config.yaml
    • Updated the package version to 1.2.0.
  • pyproject.toml
    • Updated the package version to 1.2.0 and the API specification version to 1.74.0.
  • test/test_put_scheduled_transaction_wrapper.py
    • Created a new test file for the PutScheduledTransactionWrapper model.
  • ynab/init.py
    • Updated the package version to 1.2.0 and the API version to 1.74.0.
    • Imported PutScheduledTransactionWrapper model.
  • ynab/api/scheduled_transactions_api.py
    • Added delete_scheduled_transaction and update_scheduled_transaction methods.
    • Corrected the parameter serialization for get_scheduled_transaction_by_id and get_scheduled_transactions.
  • ynab/configuration.py
    • Added ca_cert_data to the configuration options.
    • Updated the debug report to reflect the new API and SDK versions.
  • ynab/exceptions.py
    • Added exception classes for HTTP 409 Conflict and HTTP 422 Unprocessable Entity.
  • ynab/models/init.py
    • Imported PutScheduledTransactionWrapper model.
  • ynab/models/save_category.py
    • Added goal_target property to the SaveCategory model.
  • ynab/models/scheduled_sub_transaction.py
    • Added payee_name and category_name properties to the ScheduledSubTransaction model.
  • ynab/rest.py
    • Added ca_cert_data to the pool arguments.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A scheduled task, now freed to roam,
With PUT and DELETE, it finds its home.
Payee and category, names now clear,
Goals can be updated, banish all fear!

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist
Copy link

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@bradymholt bradymholt merged commit 2ff28ff into main Mar 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants