OpenRV integration by ddesmond · Pull Request #4839 · ynput/OpenPype

ddesmond · 2023-04-13T07:39:01Z

Changelog Description

Draft OpenRV integration including Ftrack support
Features:

View FTrack action, Review Ftrack action
OpenPype Menus package
OpenPype Comments package
Loading and Publising annotations

Additional info

You need to compile OpenRV first, head to OpenRV github and do it!

TODO

to have a review session you need a task in ftrack where RV can hook to -> in my case ive setup/hardcoded
task_name = "prepDaily"
asset_name = "DaliesPrep"
so RV can have its session files stored with a proper task. this should be somehow parametrized ?

Roy: Untested - still todo.

TODO

Testing notes

Run OpenRV through OpenPype and go crazy
Test the ftrack actions to see whether they do what they should

BigRoy

Great stuff. There are quite a few cosmetic things the hound trips over. Would you like me to clean that up for you? I can push directly into your branch (if you'd like that) or create a PR to your repo if you prefer that?

openpype/hosts/openrv/plugins/load/load_frames.py

openpype/hosts/openrv/startup/pkgs_source/comments/PACKAGE

openpype/settings/entities/schemas/projects_schema/schemas/schema_openrv_publish.json

openpype/hosts/openrv/addon.py

openpype/hosts/openrv/api/commands.py

…gration

ddesmond · 2023-04-13T09:20:09Z

Great stuff. There are quite a few cosmetic things the hound trips over. Would you like me to clean that up for you? I can push directly into your branch (if you'd like that) or create a PR to your repo if you prefer that?

push directly to my branch

openpype/hosts/openrv/hooks/pre_debughooks.py

openpype/hosts/openrv/plugins/create/create_debug.py

openpype/hosts/openrv/hooks/pre_config_setup.py

BigRoy · 2023-04-18T15:15:49Z

This PR isn't finished but I'm marking it for review anyway - there are definitely things that need cleaning up before it can get merged but there's also already a lot which should be up for discussion and testing.

What is there now?

@ddesmond code has been refactored to:

remove unused code
add docstring + comment code here and there
refactored to use new publisher
some additional features fixed like OCIO support + open last workfile, etc.
there is a bit of 'auto-install' stuff and a script editor exposed in OpenRV now to ease debugging/usage
OpenPype menu with the tools showing structured like it is in other hosts
loading containers works for videos + sequences and supports the colorspace data

What to do next?

Required before merge

see bullet point todo list in original post
refactor auto-install on startup that doesn't "nest itself" inside of OpenPype deployment
finish support annotation publishing (or remove it and keep for later PR)
- I will create a forum discussion related to this to discuss how we'd want to publish "annotations" related to a publish in OpenPype.
finish support for ftrack actions to open a review (or remove it and keep for later PR)
finish support for the "review" package that is in this PR for OpenRV. However it's currently a bit wonky in functionality and far from polished finished. I'd say it's likely best to push that out of the base OpenRV PR and separate that into a PR of its own.

Nice to have*

fix Qt styling

Who do we have available to test this PR?

BigRoy · 2023-04-18T15:33:30Z

Here's a screen capture of the current state of this PR with some notes as a ramble on about it and misclick half of the UI buttons the whole time.

openpype_openrv_state_2023-18-04_PR.mp4

BigRoy

Some comments to highlight todos.

openpype/hosts/openrv/addon.py

openpype/hosts/openrv/api/commands.py

BigRoy · 2023-04-18T15:43:21Z

openpype/hosts/openrv/api/ocio.py

+This tries to set the relevant OCIO settings on the group's look and render
+pipeline similar to what the OpenColorIO Basic Color Management package does in
+OpenRV through its `ocio_source_setup` python file.


It would be great if we could also autoload this package - but I know too little of RV to say what the best approach is to do so.

I've asked more information about this on the Shotgrid Software community about Autoload OpenColorIO Basic Color Management RV package.

openpype/hosts/openrv/api/pipeline.py

BigRoy · 2023-04-18T15:44:34Z

openpype/hosts/openrv/api/review.py

These functions are basically untested at this stage as far as I know.

openpype/hosts/openrv/hooks/pre_setup_openrv.py

BigRoy · 2023-04-18T15:46:04Z

openpype/hosts/openrv/plugins/publish/extract_annotations.py

Pretty much haven't worked on this extractor at all - it's clearly WIP still.

…ned RV_SUPPORT_PATH paths

rontown · 2023-11-04T19:42:01Z

Interesting to see you successfully compiled a version of OpenRV.
Ive been trying on and off to compile it on windows 10 and rocky 9.2 for months to no avail. Even more exciting to see the developing integration with openpype/ayon!

antirotor · 2023-11-23T14:03:51Z

Interesting to see you successfully compiled a version of OpenRV.
Ive been trying on and off to compile it on windows 10 and rocky 9.2 for months to no avail. Even more exciting to see the developing integration with openpype/ayon!

Building on Windows does work, just follow closely this guide - AcademySoftwareFoundation/OpenRV#91

iLLiCiTiT · 2023-12-21T13:59:27Z

openpype/hosts/openrv/hooks/pre_setup_openrv.py

+
+        executable = self.application.find_executable()
+        if not executable:
+            self.log.error("Unable to find executable for RV.")
+            return
+


It would not get to prelaunch hook if executable would not be found.

Suggested change

executable = self.application.find_executable()

if not executable:

self.log.error("Unable to find executable for RV.")

return

executable = self.executable.executable_path

The executable path is still needed for the logic below - so I guess it's just the if statement that you want removed, not the find_executable? Or is there a better way in the prelaunch hook to get the executable path?

Modified suggestion

For what it's worth and for your information:

This PR was originally opened by @ddesmond

I contributed into the PR at the time because I could because I had write permissions to the repo - I currently don't anymore so I am personally unable to contribute to this PR.

I believe @ddesmond is not working on this feature currently meaning that without other contributions from someone with write access this will end up staying as a stale PR.

If you need permissions i can give some to you @BigRoy

there is also ddesmond#8
You have been added as a colab to my repo @BigRoy , let me know guys if you need more help

kalisp · 2024-02-01T12:32:49Z

Closing this one in favor of #6185 - which cleans up a bit this one, translates it into Ayon addon.

Any comments welcomed in that PR or in Issues in https://github.com/ynput/ayon-openrv

openrv integration

3e743ac

ynbot added module: Ftrack size/XL Denotes a PR changes 1500-2499 lines, ignoring general files labels Apr 13, 2023

tokejepsen self-assigned this Apr 13, 2023

ddesmond marked this pull request as draft April 13, 2023 08:12

BigRoy reviewed Apr 13, 2023

View reviewed changes

BigRoy added 9 commits April 13, 2023 11:02

Code cosmetics

4ec6643

Code cosmetics + cleanup

25669f8

Re-use method from host

7bae5de

Remove unused function which likely came from Fusion or Clarisse inte…

ee5944d

…gration

Cleanup comments

a37ddad

Cosmetics

751005d

Fix missing import, not sure if there was a reason it had no top import

8250f5e

Fix typo

18be311

Shush hound

26d6f60

BigRoy reviewed Apr 13, 2023

View reviewed changes

openpype/hosts/openrv/hooks/pre_debughooks.py Outdated Show resolved Hide resolved

BigRoy reviewed Apr 13, 2023

View reviewed changes

openpype/hosts/openrv/plugins/create/create_debug.py Outdated Show resolved Hide resolved

Remove unused show_env

8d563b0

BigRoy reviewed Apr 13, 2023

View reviewed changes

openpype/hosts/openrv/hooks/pre_config_setup.py Outdated Show resolved Hide resolved

BigRoy requested a review from tokejepsen April 13, 2023 09:34

BigRoy added 9 commits April 13, 2023 13:18

Cleanup code

289fea4

Remove debug files

b376efb

More cleanup

d10b2de

Return if there's no current workfile

fed5549

Cosmetics

aa9766c

Cosmetics + Shush hound

3c636d6

Remove unused function

8d0d2bf

Merge remote-tracking branch 'upstream/develop' into openrv-integration

6092fa5

Cosmetics

de715e7

BigRoy added 2 commits April 18, 2023 14:46

Nicer label + docstring

dd664c8

Add comment about a workaround

81d5d16

BigRoy marked this pull request as ready for review April 18, 2023 15:02

BigRoy reviewed Apr 18, 2023

View reviewed changes

BigRoy added 2 commits April 18, 2023 20:20

Cleanup reset_frame_range logic. Remove old edit_in and edit_out

fce4e7d

Remove redundant adding of vendor/python

1da142c

mkolar added the sponsored Client endorsed or requested label Apr 19, 2023

BigRoy added 6 commits April 24, 2023 13:11

Merge branch 'develop' into openrv-integration

26c8f29

Merge branch 'develop' into openrv-integration

74779ce

Preserve predefined RV_SUPPORT_PATH paths

a2b37e9

Install OpenPype packages to temp folder on launch + preserve predefi…

aa74663

…ned RV_SUPPORT_PATH paths

Remove unused import

4e41b48

Force rvpkg just to be sure it's not trying to be used interactively

0dda77b

BigRoy changed the title ~~Draft: OpenRV integration~~ OpenRV integration Apr 25, 2023

BigRoy mentioned this pull request Jun 2, 2023

Enhancement: Access or embed AYON's Python Script Editor in hosts ynput/ayon-core#743

Open

2 tasks

This was referenced Jun 22, 2023

Enhancement/nuke openrv integration #5178

Closed

add rv integration in nuke ddesmond/OpenPype#8

Open

MustafaJafar added the community contribution label Jun 30, 2023

ccaillot mentioned this pull request Oct 20, 2023

Add OpenRV quadproduction/OpenPype#590

Closed

Merge branch 'develop' into openrv-integration

3493817

♻️ update color management settings

305efbb

iLLiCiTiT reviewed Dec 21, 2023

View reviewed changes

iLLiCiTiT added the target: OpenPype label Dec 21, 2023

kalisp closed this Feb 1, 2024

ynbot added this to the next-patch milestone Feb 1, 2024

Conversation

ddesmond commented Apr 13, 2023 • edited by BigRoy Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog Description

Additional info

TODO

Testing notes

Uh oh!

BigRoy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ddesmond commented Apr 13, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BigRoy commented Apr 18, 2023

What is there now?

What to do next?

Uh oh!

BigRoy commented Apr 18, 2023

Uh oh!

BigRoy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rontown commented Nov 4, 2023

Uh oh!

antirotor commented Nov 23, 2023

Uh oh!

iLLiCiTiT Dec 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kalisp commented Feb 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

ddesmond commented Apr 13, 2023 •

edited by BigRoy

Loading

iLLiCiTiT Dec 21, 2023 •

edited

Loading