Skip to content

Pre-launch hook: Use addon name instead of host name as settings key#54

Merged
jakubjezek001 merged 2 commits intoynput:developfrom
BrookRaindle:ayon-flame-newbranch
Sep 9, 2025
Merged

Pre-launch hook: Use addon name instead of host name as settings key#54
jakubjezek001 merged 2 commits intoynput:developfrom
BrookRaindle:ayon-flame-newbranch

Conversation

@BrookRaindle
Copy link

Changelog Description

Use explicit addon name instead of host name to get addon settings.
Direct Port of

Additional review information

Because addon name and host name are same it did work, but code-wise is confusing. It should look explicitly for addon name, not host name (confusing those who use other addons as example).

Testing notes:

  1. Validate the reasoning of the change.
  2. Nothing really changed technically.

@jakubjezek001
Copy link
Member

Thank you for the suggestion @BrookRaindle. Yes it seems for some that it is confusing yet this is in consistency with other addon implementations. There might be a reason for this - I can only guess that perhaps we might need to change the host name later and this way we will not need to do replacements on multiple lines.

@BigRoy
Copy link
Contributor

BigRoy commented Apr 9, 2025

Why is this closed @jakubjezek001

I'm pretty sure @iLLiCiTiT would say this is the correct fix? Since it was also fixed for fusion for example.

@BigRoy BigRoy requested a review from iLLiCiTiT April 9, 2025 14:51
@BigRoy BigRoy added the type: enhancement Improvement of existing functionality or minor addition label Apr 9, 2025
@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Apr 10, 2025

It is indeed correct fix. It should not use host_name, even if the value is same as addon name.

@iLLiCiTiT iLLiCiTiT reopened this Apr 10, 2025
@jakubjezek001 jakubjezek001 merged commit 0b37b0e into ynput:develop Sep 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement Improvement of existing functionality or minor addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants