Pre-launch hook: Use addon name instead of host name as settings key#54
Merged
jakubjezek001 merged 2 commits intoynput:developfrom Sep 9, 2025
Merged
Conversation
Member
|
Thank you for the suggestion @BrookRaindle. Yes it seems for some that it is confusing yet this is in consistency with other addon implementations. There might be a reason for this - I can only guess that perhaps we might need to change the host name later and this way we will not need to do replacements on multiple lines. |
Contributor
|
Why is this closed @jakubjezek001 I'm pretty sure @iLLiCiTiT would say this is the correct fix? Since it was also fixed for fusion for example. |
Member
|
It is indeed correct fix. It should not use |
jakubjezek001
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Use explicit addon name instead of host name to get addon settings.
Direct Port of
Additional review information
Because addon name and host name are same it did work, but code-wise is confusing. It should look explicitly for addon name, not host name (confusing those who use other addons as example).
Testing notes: