Skip to content

Collect render instance resolution from the tool in comp instead of from comp frame format prefs#32

Merged
BigRoy merged 2 commits intoynput:developfrom
BigRoy:bugfix/collect_render_resolution_from_tool
Jan 21, 2025
Merged

Collect render instance resolution from the tool in comp instead of from comp frame format prefs#32
BigRoy merged 2 commits intoynput:developfrom
BigRoy:bugfix/collect_render_resolution_from_tool

Conversation

@BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Jan 20, 2025

Changelog Description

Collect render resolution from the actual tool in comp instead of from comp frame format prefs

Additional review information

This fixes the behavior that setting Extract Review resolution to 0x0 in settings that the resolution would be forced to the Frame Format Prefs (instead of the resolution from the rendered media)

Testing notes:

  1. Set Extract Review settings in core to use output resolution 0x0
  2. Set current context to use e.g. resolution 1000x1000
  3. Create a render graph that actually renders e.g. 300x200
  4. Publish it (disable resolution validator of course)
  5. The generated review should be 300x200.

@BigRoy BigRoy added the type: bug Something isn't working label Jan 20, 2025
@BigRoy BigRoy self-assigned this Jan 20, 2025
@BigRoy BigRoy marked this pull request as ready for review January 21, 2025 12:20
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have followed the testing steps and all working as expected and without any glitches.

image

I was abe to produce render having exclusive resolution compared to my folder resolution.

All good and properly integrated on AYON and having custom of 720x405 compared to folder resolution 960x540

@BigRoy BigRoy merged commit 7f4056e into ynput:develop Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants