feat: Add image preview and remove action in block editor#33
Open
jojo58fr wants to merge 2 commits intoyoanbernabeu:mainfrom
Open
feat: Add image preview and remove action in block editor#33jojo58fr wants to merge 2 commits intoyoanbernabeu:mainfrom
jojo58fr wants to merge 2 commits intoyoanbernabeu:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds image preview support in the block editor sidebar after upload, along with a dedicated
Remove imageaction.This change improves the image upload UX for
MEDIAandLINKblocks by:Remove imagebutton size/style with the existingRemove BlockactionRelated Issue
Type of Change
Checklist
npm run lintand fixed any issuesnpm run formatto format my codenpm run type-checkwith no errorsnpm run devScreenshots (if applicable)
Additional Notes
In addition to the image upload UX update, this branch also includes small repository fixes required to make the validation checks pass cleanly:
SettingsModalblocks callback prop usage in the builderValidation completed on this branch:
npm run lintnpm run formatnpm run type-check