Skip to content

Replace Prettier by oxfmt#177

Closed
yoavbls wants to merge 7 commits intomainfrom
replace-prettier-by-oxfmt
Closed

Replace Prettier by oxfmt#177
yoavbls wants to merge 7 commits intomainfrom
replace-prettier-by-oxfmt

Conversation

@yoavbls
Copy link
Owner

@yoavbls yoavbls commented Feb 28, 2026

Performance boost with oxfmt,
Change the API to be async and run few diagnostic formatting in parallel

@yoavbls yoavbls force-pushed the replace-prettier-by-oxfmt branch from 642b83c to cba392a Compare February 28, 2026 23:44
@yoavbls
Copy link
Owner Author

yoavbls commented Mar 1, 2026

@kevinramharak I would like you to take a look if you can 🙂
I didn't commit some required file renames yet because I wanted the git history to be preserved

@yoavbls
Copy link
Owner Author

yoavbls commented Mar 1, 2026

NVM, format with oxfmt made it too complex and 10x bigger vsix file.
The performance boost wasn't significant either way

@yoavbls yoavbls closed this Mar 1, 2026
@kevinramharak
Copy link
Collaborator

@yoavbls :D, yeah the oxc stuff is interesting, but its written in rust, so compiled down to wasm, which bloats the size a lot.

@yoavbls
Copy link
Owner Author

yoavbls commented Mar 2, 2026

They didn't ship the WASM version yet, currently it's a .node module for every platform (downloading the right binary for the platform when npm install oxfmt)
So it required this complex matrix to publish:
https://github.com/yoavbls/pretty-ts-errors/pull/177/changes#diff-298b386bbf2343fd191d093150558ce0a8462e382a8c9d74b035270efe216996R29-R68

I thought it's too much so I rolled back to prettier + upgraded to 3.x, which is also async apu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants