-
Notifications
You must be signed in to change notification settings - Fork 18
Tag 3.9.0 #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag 3.9.0 #46
Conversation
|
@JPEWdev Hi, you were extremely helpful in the past, so I don't want to bug you too much. But considering the upcoming Debian Trixie freeze I wanted to send you a friendly ping to maybe consider adding a new release tag for bmaptool that we can then package for Debian before its too late. Thank you! |
|
Makes sense. Thanks for making the changelog changes; it looks like the version in CLI.py needs change. Do you know how to do the debian package updates? I'm not really familiar with the process |
|
Whoops! The fact that the last upload missed the respective entries in
Yes, I'm a Debian Developer so that part is easy for me. I modernized the packaging while I was at it. Ping me if there should be any problems with the Debian packaging side of things. Unfortunately I'm a complete rpm noob which is why I left the author in |
|
Linting should be fixed in #48 |
|
I also only just now saw the script |
|
Ah, let me try it |
I fixed a few of the obvious issues. What I do not understand is what the |
The release script had a few bashisms, as well as a non-portable usage of the fold command. Additional, do not have the script make the tag or force changes to be on the main branch, since we would prefer to draft a GitHub release to make releases instead of force pushing tags
Signed-off-by: Joshua Watt <[email protected]>
|
Ok, the script takes care of most of it after I fixed it up. Would you mind looking at #49? I change the script because I would much rather make the release in GitHub than force push a tag Also, your debian cleanup looks pretty good, so lets still do that |
Dunno. I would guess it's a unicode thing, but columns should be fine |
I guess the only more critical missing part was the entries in |
- replace docs/RELEASE_NOTES by CHANGELOG.md and README.md - install docs/man1/bmaptool.1 - use debhelper-compat B-D instead of debian/compat - bump dh compat to 13 - add new build dependencies - bump Standards-Version to 4.7.0 - add Homepage field to d/control - use dependencies from packaging in Debian - use https URI in d/copyright - replace --with=python3 with --buildsystem=pybuild - use pybuild-plugin-pyproject - select 3.0 (native) source format
Reformats with the latest version of black that changes a few things Signed-off-by: Joshua Watt <[email protected]>
|
In an attempt to make things a bit less confusing, I rebased my changes from this PR on top of your changes in #49. So now you can easily see what's different and cherry-pick the things you like. :) |
|
That works, thank you. I would have done it but I was away :) |
To be able to maybe add another git tag soon, I wrote a draft for the new changelog entry.