Skip to content

Conversation

@josch
Copy link

@josch josch commented Feb 18, 2025

To be able to maybe add another git tag soon, I wrote a draft for the new changelog entry.

@josch josch changed the title Tag 3.9 Tag 3.9.0 Feb 18, 2025
@josch
Copy link
Author

josch commented Mar 14, 2025

@JPEWdev Hi, you were extremely helpful in the past, so I don't want to bug you too much. But considering the upcoming Debian Trixie freeze I wanted to send you a friendly ping to maybe consider adding a new release tag for bmaptool that we can then package for Debian before its too late. Thank you!

@JPEWdev
Copy link
Collaborator

JPEWdev commented Mar 14, 2025

Makes sense. Thanks for making the changelog changes; it looks like the version in CLI.py needs change. Do you know how to do the debian package updates? I'm not really familiar with the process

@josch
Copy link
Author

josch commented Mar 14, 2025

Whoops! The fact that the last upload missed the respective entries in CHANGELOG.md made me not even check what the last released changed. I now adjusted the commit to change all the things that were changed for the last release including:

  • CHANGELOG.md
  • debian/changelog
  • docs/man1/bmaptool.1
  • packaging/bmaptool.changes
  • packaging/bmaptool.spec
  • src/bmaptool/CLI.py

Do you know how to do the debian package updates? I'm not really familiar with the process

Yes, I'm a Debian Developer so that part is easy for me. I modernized the packaging while I was at it. Ping me if there should be any problems with the Debian packaging side of things.

Unfortunately I'm a complete rpm noob which is why I left the author in packaging/bmaptool.changes as FIXME. Somebody other than me should have their name there.

@JPEWdev
Copy link
Collaborator

JPEWdev commented Mar 14, 2025

Linting should be fixed in #48

@josch
Copy link
Author

josch commented Mar 14, 2025

I also only just now saw the script make_a_release.sh. I haven't used that one. I'm not familiar with it and have to investigate unless you know how to use it?

@JPEWdev
Copy link
Collaborator

JPEWdev commented Mar 14, 2025

Ah, let me try it

@josch
Copy link
Author

josch commented Mar 14, 2025

Ah, let me try it

I fixed a few of the obvious issues.

What I do not understand is what the -c argument to fold is supposed to do. GNU coreutils fold does not have that. Which other version of fold is expected here?

JPEWdev added 2 commits March 14, 2025 13:46
The release script had a few bashisms, as well as a non-portable usage
of the fold command.

Additional, do not have the script make the tag or force changes to be
on the main branch, since we would prefer to draft a GitHub release to
make releases instead of force pushing tags
Signed-off-by: Joshua Watt <[email protected]>
@JPEWdev
Copy link
Collaborator

JPEWdev commented Mar 14, 2025

Ok, the script takes care of most of it after I fixed it up. Would you mind looking at #49?

I change the script because I would much rather make the release in GitHub than force push a tag

Also, your debian cleanup looks pretty good, so lets still do that

@JPEWdev
Copy link
Collaborator

JPEWdev commented Mar 14, 2025

Ah, let me try it

I fixed a few of the obvious issues.

What I do not understand is what the -c argument to fold is supposed to do. GNU coreutils fold does not have that. Which other version of fold is expected here?

Dunno. I would guess it's a unicode thing, but columns should be fine

@josch josch mentioned this pull request Mar 14, 2025
@josch
Copy link
Author

josch commented Mar 14, 2025

Would you mind looking at #49?

I guess the only more critical missing part was the entries in CHANGELOG.md. Thank you! :)

josch and others added 5 commits March 18, 2025 10:15
 - replace docs/RELEASE_NOTES by CHANGELOG.md and README.md
 - install docs/man1/bmaptool.1
 - use debhelper-compat B-D instead of debian/compat
 - bump dh compat to 13
 - add new build dependencies
 - bump Standards-Version to 4.7.0
 - add Homepage field to d/control
 - use dependencies from packaging in Debian
 - use https URI in d/copyright
 - replace --with=python3 with --buildsystem=pybuild
 - use pybuild-plugin-pyproject
 - select 3.0 (native) source format
Reformats with the latest version of black that changes a few things

Signed-off-by: Joshua Watt <[email protected]>
@josch
Copy link
Author

josch commented Mar 18, 2025

In an attempt to make things a bit less confusing, I rebased my changes from this PR on top of your changes in #49. So now you can easily see what's different and cherry-pick the things you like. :)

@JPEWdev
Copy link
Collaborator

JPEWdev commented Mar 18, 2025

That works, thank you. I would have done it but I was away :)

@JPEWdev JPEWdev merged commit 618a731 into yoctoproject:main Mar 18, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants