bug: Fix importing and displaying of hackerone assets that are classified under OTHER#1440
Open
yogeshojha wants to merge 4 commits intomasterfrom
Open
Conversation
1 task
Contributor
|
Woohoo @yogeshojha! 🎉 You've just dropped some hot new code! 🔥 Hang tight while we review this! You rock! 🤘 |
1 similar comment
Contributor
|
Woohoo @yogeshojha! 🎉 You've just dropped some hot new code! 🔥 Hang tight while we review this! You rock! 🤘 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported by @r3dpars3c that BountyHub isnt able to import domains that has wildcard plus those domains that are under OTHER asset type.
These changes introduce a util function to verify if the asset is supported by reNgine or not.
The other util function removes wildcard before inserting into db, happens during import phase, but during the UI/FE wildcards will still be shown as wildcard.