Fix invalid IP address storage by using host_ip instead of host#1535
Open
w1ld3r wants to merge 20 commits intoyogeshojha:masterfrom
Open
Fix invalid IP address storage by using host_ip instead of host#1535w1ld3r wants to merge 20 commits intoyogeshojha:masterfrom
host_ip instead of host#1535w1ld3r wants to merge 20 commits intoyogeshojha:masterfrom
Conversation
Resolve popen split
Contributor
|
Woohoo @w1ld3r! 🎉 You've just dropped some hot new code! 🔥 Hang tight while we review this! You rock! 🤘 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved an issue where the HTTP crawl task attempted to save the
hostvalue from thehttpxresponse as an IP address, causing validation errors when the value was a domain name. The fix ensures that only thehost_ipfield returned byhttpx—which contains a valid IP address—is used when creating IP address records.Resolve an issue where WHOIS data was not retrieved when no Netlas API key was configured. The problem was caused by an incorrect comparison that treated the string 'None' as a valid key. This fix ensures that only valid, non-None keys are appended to the command, preventing the task from attempting to use invalid API keys.