Fix CSV import/export to properly handle commas in link names #144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a link name contained a comma, the CSV export would not properly escape it, causing the import to incorrectly split the name across multiple columns.
For example, a link with name "My Favorite Sites, Part 1" would be exported as:
This would be incorrectly parsed as 6 columns instead of 4, with the name split into "My Favorite Sites" and " Part 1", resulting in data loss during import.
Solution
Export Fix (ExportRepositoryImpl.kt)
Replaced manual string interpolation with OpenCSV's
CSVWriter
API, which automatically handles proper escaping of commas, quotes, and newlines according to RFC 4180 standards:Before:
After:
Import Fix (ImportRepositoryImpl.kt)
Updated the import logic to properly handle the NAME column and support both new properly-escaped CSVs and legacy improperly-formatted ones:
Before:
After:
This approach:
Testing
Added comprehensive unit tests (
CsvExportImportTest.kt
) that verify:Result
With these changes, a link with name "My Favorite Sites, Part 1" will now be correctly exported as:
And correctly imported with the full name intact.
Compatibility
✅ Forward Compatibility: New CSV exports are properly formatted with RFC 4180 compliant escaping
✅ Backward Compatibility: Import can still read old improperly formatted CSV files by joining split name columns
Fixes the issue where commas in link names caused data corruption during CSV export/import.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dl.google.com
/usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -Xmx2048m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.13-bin/5xuhj0ry160q40clulazy9h7d/gradle-8.13/lib/gradle-daemon-main-8.13.jar -javaagent:/home/REDACTED/.gradle/wrapper/dists/gradle-8.13-bin/5xuhj0ry160q40clulazy9h7d/gradle-8.13/lib/agents/gradle-instrumentation-agent-8.13.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 8.13
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.