-
-
Notifications
You must be signed in to change notification settings - Fork 99
Translations update from Hosted Weblate #1240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Currently translated at 100.0% (137 of 137 strings) Translation: KeyPass/KeyPass Translate-URL: https://hosted.weblate.org/projects/keypass/keypass/pt_BR/
WalkthroughThis pull request updates Portuguese (Brazil) string resources with revised wording and improved tone across seven UI strings, including credential restoration, backup import options, and keyphrase-related prompts. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes — Single localization file with straightforward string text updates; no logic, code structure, or functional changes to review. Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
app/src/main/res/values-pt-rBR/strings.xml (2)
92-92: Use consistent noun form "Exportação" instead of verb "Exporta".Line 92 uses the verb form "Exporta" while lines 93 and 94 use the noun form "Exportação". For consistency with the other export-related strings, this should use the noun form.
Apply this diff:
- <string name="google_backup">Exporta Senhas Chrome/Google</string> + <string name="google_backup">Exportação de Senhas Chrome/Google</string>
123-123: Use consistent terminology: "frase-chave" instead of "Keyphrase".Throughout the file, "frase-chave" is consistently used as the Portuguese translation for "keyphrase" (see lines 57, 58, 59, 61, 62, 63, 65, 66, 118, 119, 120, 124, 125). Line 123 should follow this established convention.
Apply this diff:
- <string name="forgot_keyphrase">Esqueceu Keyphrase</string> + <string name="forgot_keyphrase">Esqueceu a frase-chave</string>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/src/main/res/values-pt-rBR/strings.xml(5 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Tests and Build Production Debug Build
🔇 Additional comments (2)
app/src/main/res/values-pt-rBR/strings.xml (2)
14-14: LGTM! Improved clarity and tone.These changes improve the user experience:
- Line 14 provides more specific context about restoring passwords from backup
- Line 59 adds "Por favor" for a more polite tone
Also applies to: 59-59
103-103: LGTM! Clear and properly translated.These changes successfully:
- Line 103: Provides clearer instructions for KeePass CSV import
- Line 109: Completes the translation of a previously untranslated string
Also applies to: 109-109
Translations update from Hosted Weblate for KeyPass/KeyPass.
Current translation status:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.