almost set

Author: wonderinghost

code/__DEFINES/_helpers.dm

@@ -1,3 +1,18 @@
+// Stuff that is relatively "core" and is used in other defines/helpers
+
+/**
+ * The game's world.icon_size. \
+ * Ideally divisible by 16. \
+ * Ideally a number, but it
+ * can be a string ("32x32"), so more exotic coders
+ * will be sad if you use this in math.
+ */
+#define ICON_SIZE_ALL 32
+/// The X/Width dimension of ICON_SIZE. This will more than likely be the bigger axis.
+#define ICON_SIZE_X 32
+/// The Y/Height dimension of ICON_SIZE. This will more than likely be the smaller axis.
+#define ICON_SIZE_Y 32
+
 /// Takes a datum as input, returns its ref string
 #define text_ref(datum) ref(datum)
 

code/__DEFINES/radio.dm

@@ -114,3 +114,20 @@
 #define REQ_DEP_TYPE_ASSISTANCE 	(1<<0)
 #define REQ_DEP_TYPE_SUPPLIES 		(1<<1)
 #define REQ_DEP_TYPE_INFORMATION 	(1<<2)
+
+///give this to can_receive to specify that there is no restriction on what z level this signal is sent to
+#define RADIO_NO_Z_LEVEL_RESTRICTION 0
+
+/// Radio frequency is unlocked and can be ajusted by anyone
+#define RADIO_FREQENCY_UNLOCKED 0
+/// Radio frequency is locked, unchangeable by players
+#define RADIO_FREQENCY_LOCKED 1
+/// Radio frequency is locked and unchangeable, but can be unlocked by an emag
+#define RADIO_FREQENCY_EMAGGABLE_LOCK 2
+
+///Bitflag for if a headset can use the syndicate radio channel
+#define RADIO_SPECIAL_SYNDIE (1<<0)
+///Bitflag for if a headset can use the centcom radio channel
+#define RADIO_SPECIAL_CENTCOM (1<<1)
+///Bitflag for if a headset can use the binary radio channel
+#define RADIO_SPECIAL_BINARY (1<<2)

code/__HELPERS/_lists.dm

@@ -52,6 +52,8 @@
 #define LAZYINITLIST(L) if (!L) { L = list(); }
 ///If the provided list is empty, set it to null
 #define UNSETEMPTY(L) if (L && !length(L)) L = null
+///If the provided key -> list is empty, remove it from the list
+#define ASSOC_UNSETEMPTY(L, K) if (!length(L[K])) L -= K;
 ///Remove an item from the list, set the list to null if empty
 #define LAZYREMOVE(L, I) if(L) { L -= I; if(!length(L)) { L = null; } }
 ///Add an item to the list, if the list is null it will initialize it

code/__HELPERS/game.dm

@@ -29,19 +29,6 @@
 
 
 
-//This is the new version of recursive_mob_check, used for say().
-//The other proc was left intact because morgue trays use it.
-//Sped this up again for real this time
-/proc/recursive_hear_check(O)
-	var/list/processing_list = list(O)
-	. = list()
-	var/i = 0
-	while(i < length(processing_list))
-		var/atom/A = processing_list[++i]
-		if(A.flags_1 & HEAR_1)
-			. += A
-		processing_list += A.contents
-
 /** recursive_organ_check
   * inputs: O (object to start with)
   * outputs:
@@ -79,47 +66,12 @@
 
 	return
 
-// Better recursive loop, technically sort of not actually recursive cause that shit is stupid, enjoy.
-//No need for a recursive limit either
-/proc/recursive_mob_check(atom/O,client_check=1,sight_check=1,include_radio=1)
-
-	var/list/processing_list = list(O)
-	var/list/processed_list = list()
-	var/list/found_mobs = list()
-
-	while(processing_list.len)
-
-		var/atom/A = processing_list[1]
-		var/passed = 0
-
-		if(ismob(A))
-			var/mob/A_tmp = A
-			passed=1
-
-			if(client_check && !A_tmp.client)
-				passed=0
-
-			if(sight_check && !isInSight(A_tmp, O))
-				passed=0
-
-		else if(include_radio && istype(A, /obj/item/radio))
-			passed=1
-
-			if(sight_check && !isInSight(A, O))
-				passed=0
-
-		if(passed)
-			found_mobs |= A
-
-		for(var/atom/B in A)
-			if(!processed_list[B])
-				processing_list |= B
-
-		processing_list.Cut(1, 2)
-		processed_list[A] = A
-
-	return found_mobs
-
+///Returns the name of the area the atom is in
+/proc/get_area_name(atom/checked_atom, format_text = FALSE)
+	var/area/checked_area = isarea(checked_atom) ? checked_atom : get_area(checked_atom)
+	if(!checked_area)
+		return null
+	return format_text ? format_text(checked_area.name) : checked_area.name
 
 /proc/get_cardinal_step_away(atom/start, atom/finish) //returns the position of a step from start away from finish, in one of the cardinal directions
 	//returns only NORTH, SOUTH, EAST, or WEST

code/__HELPERS/spatial_info.dm

@@ -295,11 +295,11 @@
 	return atoms
 
 ///Returns the distance between two atoms
-/proc/get_dist_euclidean(atom/first_location, atom/second_location)
-	var/dx = first_location.x - second_location.x
-	var/dy = first_location.y - second_location.y
+/proc/get_dist_euclidian(atom/Loc1 as turf|mob|obj,atom/Loc2 as turf|mob|obj)
+	var/dx = Loc1.x - Loc2.x
+	var/dy = Loc1.y - Loc2.y
 
-	var/dist = sqrt(dx ** 2 + dy ** 2)
+	var/dist = sqrt(dx**2 + dy**2)
 
 	return dist
 
@@ -318,7 +318,7 @@
 	return turfs
 
 ///Returns a list of turfs around a center based on view()
-/proc/circle_view_turfs(center=usr,radius=3) //Is there even a diffrence between this proc and circle_range_turfs()? // Yes
+/proc/circleviewturfs(center=usr,radius=3) //Is there even a diffrence between this proc and circle_range_turfs()? // Yes
 	var/turf/center_turf = get_turf(center)
 	var/list/turfs = new/list()
 	var/rsq = radius * (radius + 0.5)
@@ -441,7 +441,7 @@
 		get_area(get_ranged_target_turf(center, EAST, 1)),
 		get_area(get_ranged_target_turf(center, WEST, 1))
 		)
-	list_clear_nulls(.)
+	listclearnulls(.)
 
 ///Checks if the mob provided (must_be_alone) is alone in an area
 /proc/alone_in_area(area/the_area, mob/must_be_alone, check_type = /mob/living/carbon)
@@ -462,7 +462,7 @@
  * @params outer_range - The outer range of the cicle to pull from.
  * @params inner_range - The inner range of the circle to NOT pull from.
  * @params center - The center of the circle to pull from, can be an atom (we'll apply get_turf() to it within circle_x_turfs procs.)
- * @params view_based - If TRUE, we'll use circle_view_turfs instead of circle_range_turfs procs.
+ * @params view_based - If TRUE, we'll use circleviewturfs instead of circle_range_turfs procs.
  */
 /proc/turf_peel(outer_range, inner_range, center, view_based = FALSE)
 	if(inner_range > outer_range) // If the inner range is larger than the outer range, you're using this wrong.
@@ -471,8 +471,8 @@
 	var/list/outer
 	var/list/inner
 	if(view_based)
-		outer = circle_view_turfs(center, outer_range)
-		inner = circle_view_turfs(center, inner_range)
+		outer = circleviewturfs(center, outer_range)
+		inner = circleviewturfs(center, inner_range)
 	else
 		outer = circle_range_turfs(center, outer_range)
 		inner = circle_range_turfs(center, inner_range)

code/game/area/areas.dm

@@ -782,10 +782,10 @@ GLOBAL_LIST_EMPTY(teleportlocs)
 	set waitfor = FALSE
 	SEND_SIGNAL(src, COMSIG_AREA_ENTERED, arrived, old_area)
 
-	if(!LAZYACCESS(arrived.important_recursive_contents, RECURSIVE_CONTENTS_AREA_SENSITIVE))
+	if(!arrived.important_recursive_contents?[RECURSIVE_CONTENTS_AREA_SENSITIVE])
 		return
 	for(var/atom/movable/recipient as anything in arrived.important_recursive_contents[RECURSIVE_CONTENTS_AREA_SENSITIVE])
-		SEND_SIGNAL(M, COMSIG_ENTER_AREA, src) //The atom that enters the area
+		SEND_SIGNAL(recipient, COMSIG_ENTER_AREA, src)
 
 /**
   * Called when an atom exits an area

code/game/machinery/sci_bombardment.dm

@@ -52,7 +52,7 @@
 			lavaland = Z
 			break
 	radio = new /obj/item/radio/(src)
-	radio.frequency = radio_freq
+	radio.set_frequency(radio_freq)
 	update_appearance()
 
 /obj/machinery/sci_bombardment/Destroy()

code/game/machinery/telecomms/telecomunications.dm

@@ -49,6 +49,11 @@ GLOBAL_LIST_EMPTY(telecomms_list)
 	/// Is it a hidden machine?
 	var/hide = FALSE
 
+	var/net_efective = 100 //yogs percentage of netspeed aplied
+	var/generates_heat = TRUE 	//yogs turn off tcomms generating heat
+	var/heatoutput = 2500		//yogs modify power output per trafic removed(usual heat capacity of the air in server room is 1600J/K)
+
+	var/on_icon = "" // used for special cases broadcaster/reciever
 	///Looping sounds for any servers
 	var/datum/looping_sound/server/soundloop
 

code/game/objects/items/devices/radio/radio.dm

@@ -107,7 +107,6 @@ GLOBAL_LIST_INIT(channel_tokens, list(
 	set_frequency(sanitize_frequency(frequency, freerange))
 	set_on(on)
 
-	AddElement(/datum/element/empprotection, EMP_PROTECT_WIRES)
 
 /obj/item/radio/Destroy()
 	remove_radio_all(src) //Just to be sure
@@ -242,17 +241,17 @@ GLOBAL_LIST_INIT(channel_tokens, list(
 		set_listening(FALSE, actual_setting = FALSE)
 
 /obj/item/radio/talk_into(atom/movable/talking_movable, message, channel, list/spans, datum/language/language, list/message_mods)
-	if(HAS_TRAIT(talking_movable, TRAIT_SIGN_LANG)) //Forces Sign Language users to wear the translation gloves to speak over radios
-		var/mob/living/carbon/mute = talking_movable
-		if(istype(mute))
-			var/obj/item/clothing/gloves/radio/G = mute.get_item_by_slot(ITEM_SLOT_GLOVES)
-			if(!istype(G))
-				return FALSE
-			switch(mute.check_signables_state())
-				if(SIGN_ONE_HAND) // One hand full
-					message = stars(message)
-				if(SIGN_HANDS_FULL to SIGN_CUFFED)
-					return FALSE
+//	if(HAS_TRAIT(talking_movable, TRAIT_SIGN_LANG)) //Forces Sign Language users to wear the translation gloves to speak over radios / if implemented uncomment
+//		var/mob/living/carbon/mute = talking_movable
+//	if(istype(mute))
+//		var/obj/item/clothing/gloves/radio/G = mute.get_item_by_slot(ITEM_SLOT_GLOVES)
+//	if(!istype(G))
+//		return FALSE
+//	switch(mute.check_signables_state())
+//		if(SIGN_ONE_HAND) // One hand full
+//			message = stars(message)
+//		if(SIGN_HANDS_FULL to SIGN_CUFFED)
+//			return FALSE
 	if(!spans)
 		spans = list(talking_movable.speech_span)
 	if(!language)

code/game/objects/items/implants/implant_biosig_ert.dm

@@ -9,7 +9,7 @@
 	. = ..()
 	radio = new(src)
 	radio.keyslot = new/obj/item/encryptionkey/headset_cent // Should broadcast exclusively on the centcom channel.
-	radio.listening = FALSE
+	radio.set_listening(FALSE)
 	radio.recalculateChannels()
 
 /obj/item/implant/biosig_ert/activate(cause)