[PORT TG][OPTIMIZERS] PORTS IMPORTANT RECURSIVE CONTENTS AND POWER/MACHINE.dm improvements

code/__DEFINES/_helpers.dm

@@ -1,3 +1,18 @@
+// Stuff that is relatively "core" and is used in other defines/helpers
+
+/**
+ * The game's world.icon_size. \
+ * Ideally divisible by 16. \
+ * Ideally a number, but it
+ * can be a string ("32x32"), so more exotic coders
+ * will be sad if you use this in math.
+ */
+#define ICON_SIZE_ALL 32
+/// The X/Width dimension of ICON_SIZE. This will more than likely be the bigger axis.
+#define ICON_SIZE_X 32
+/// The Y/Height dimension of ICON_SIZE. This will more than likely be the smaller axis.
+#define ICON_SIZE_Y 32
+
 /// Takes a datum as input, returns its ref string
 #define text_ref(datum) ref(datum)
 

code/__DEFINES/dcs/signals/signals_global.dm

@@ -82,3 +82,4 @@
 #define COMSIG_DARKSPAWN_ASCENSION "!darkspawn_ascension"
 /// Global signal sent when the backrooms finishes initailizing: (No arguments)
 #define COMSIG_BACKROOMS_INITIALIZE "!backrooms_initialize"
+

code/__DEFINES/dcs/signals/signals_spatial_grid.dm

@@ -0,0 +1,6 @@
+//spatial grid signals
+
+///Called from base of /datum/controller/subsystem/spatial_grid/proc/enter_cell: (/atom/movable)
+#define SPATIAL_GRID_CELL_ENTERED(contents_type) "spatial_grid_cell_entered_[contents_type]"
+///Called from base of /datum/controller/subsystem/spatial_grid/proc/exit_cell: (/atom/movable)
+#define SPATIAL_GRID_CELL_EXITED(contents_type) "spatial_grid_cell_exited_[contents_type]"

code/__DEFINES/flags.dm

@@ -28,45 +28,43 @@ GLOBAL_LIST_INIT(bitflags, list(1, 2, 4, 8, 16, 32, 64, 128, 256, 512, 1024, 204
 
 /// item has priority to check when entering or leaving
 #define ON_BORDER_1					(1<<1)
-/// This flag is what recursive_hear_check() uses to determine wether to add an item to the hearer list or not.
-#define HEAR_1						(1<<2)
 /// Projectiels will check ricochet on things impacted that have this.
-#define CHECK_RICOCHET_1			(1<<3)
+#define CHECK_RICOCHET_1			(1<<2)
 ///specifies that this atom is a hologram that isnt real
-#define HOLOGRAM_1					(1<<4)
+#define HOLOGRAM_1					(1<<3)
 ///Whether /atom/Initialize(mapload) has already run for the object
-#define INITIALIZED_1				(1<<5)
+#define INITIALIZED_1				(1<<4)
 /// was this spawned by an admin? used for stat tracking stuff.
-#define ADMIN_SPAWNED_1 			(1<<6)
+#define ADMIN_SPAWNED_1 			(1<<5)
 /// For machines and structures that should not break into parts, eg, holodeck stuff
-#define NODECONSTRUCT_1				(1<<7)
+#define NODECONSTRUCT_1				(1<<6)
 /// Prevent clicking things below it on the same turf eg. doors/ fulltile windows
-#define PREVENT_CLICK_UNDER_1		(1<<9)
+#define PREVENT_CLICK_UNDER_1		(1<<7)
 /// Can players recolor this in-game via vendors (and maybe more if support is added)?
-#define IS_PLAYER_COLORABLE_1 (1<<10)
+#define IS_PLAYER_COLORABLE_1		(1<<8)
 /// TESLA_IGNORE grants immunity from being targeted by tesla-style electricity
-#define TESLA_IGNORE_1				(1<<11)
+#define TESLA_IGNORE_1				(1<<9)
 /// If a turf can be made dirty at roundstart. This is also used in areas.
-#define CAN_BE_DIRTY_1				(1<<12)
+#define CAN_BE_DIRTY_1				(1<<10)
 /// Should we use the initial icon for display? Mostly used by overlay only objects
-#define HTML_USE_INITAL_ICON_1 		(1<<13)
+#define HTML_USE_INITAL_ICON_1 		(1<<11)
 /// conducts electricity (metal etc.)
-#define CONDUCT_1					(1<<14)
+#define CONDUCT_1					(1<<12)
 /// should not get harmed if this gets caught by an explosion?
-#define PREVENT_CONTENTS_EXPLOSION_1 (1<<15)
+#define PREVENT_CONTENTS_EXPLOSION_1 (1<<13)
 /// should the contents of this atom be acted upon
-#define RAD_PROTECT_CONTENTS_1 		(1<<16)
+#define RAD_PROTECT_CONTENTS_1 		(1<<14)
 /// should this object be allowed to be contaminated
-#define RAD_NO_CONTAMINATE_1 		(1<<17)
+#define RAD_NO_CONTAMINATE_1 		(1<<15)
 /// Prevents most radiation on this turf from leaving it
-#define RAD_CONTAIN_CONTENTS 		(1<<18)
+#define RAD_CONTAIN_CONTENTS 		(1<<16)
 /// Is the thing currently spinning?
-#define IS_SPINNING_1 				(1<<19)
+#define IS_SPINNING_1 				(1<<17)
 /// If this atom has experienced a decal element "init finished" sourced appearance update
 /// We use this to ensure stacked decals don't double up appearance updates for no rasin
 /// Flag as an optimization, don't make this a trait without profiling
 /// Yes I know this is a stupid flag, no you can't take him from me
-#define DECAL_INIT_UPDATE_EXPERIENCED_1 (1<<20)
+#define DECAL_INIT_UPDATE_EXPERIENCED_1 (1<<18)
 
 //TURF FLAGS
 /// If a turf cant be jaunted through.

code/__DEFINES/important_recursive_contents.dm

@@ -0,0 +1,9 @@
+///the area channel of the important_recursive_contents list, everything in here will be sent a signal when their last holding object changes areas
+#define RECURSIVE_CONTENTS_AREA_SENSITIVE "recursive_contents_area_sensitive"
+///the hearing channel of the important_recursive_contents list, everything in here will count as a hearing atom
+#define RECURSIVE_CONTENTS_HEARING_SENSITIVE "recursive_contents_hearing_sensitive"
+///the client mobs channel of the important_recursive_contents list, everything in here will be a mob with an attached client
+///this is given to both a clients mob, and a clients eye, both point to the clients mob
+#define RECURSIVE_CONTENTS_CLIENT_MOBS "recursive_contents_client_mobs"
+///the parent of storage components currently shown to some client mob get this. gets removed when nothing is viewing the parent
+#define RECURSIVE_CONTENTS_ACTIVE_STORAGE "recursive_contents_active_storage"

code/__DEFINES/machines.dm

@@ -21,6 +21,8 @@
 #define IDLE_POWER_USE 1
 #define ACTIVE_POWER_USE 2
 
+#define DYNAMIC_TO_STATIC_CHANNEL(dyn_channel) (dyn_channel + (AREA_USAGE_STATIC_START - AREA_USAGE_DYNAMIC_START)) //note to future coders. look into machinery code for improvements 
+#define STATIC_TO_DYNAMIC_CHANNEL(static_channel) (static_channel - (AREA_USAGE_STATIC_START - AREA_USAGE_DYNAMIC_START))
 
 //bitflags for door switches.
 #define OPEN	(1<<0)

code/__DEFINES/radio.dm

@@ -114,3 +114,20 @@
 #define REQ_DEP_TYPE_ASSISTANCE 	(1<<0)
 #define REQ_DEP_TYPE_SUPPLIES 		(1<<1)
 #define REQ_DEP_TYPE_INFORMATION 	(1<<2)
+
+///give this to can_receive to specify that there is no restriction on what z level this signal is sent to
+#define RADIO_NO_Z_LEVEL_RESTRICTION 0
+
+/// Radio frequency is unlocked and can be ajusted by anyone
+#define RADIO_FREQENCY_UNLOCKED 0
+/// Radio frequency is locked, unchangeable by players
+#define RADIO_FREQENCY_LOCKED 1
+/// Radio frequency is locked and unchangeable, but can be unlocked by an emag
+#define RADIO_FREQENCY_EMAGGABLE_LOCK 2
+
+///Bitflag for if a headset can use the syndicate radio channel
+#define RADIO_SPECIAL_SYNDIE (1<<0)
+///Bitflag for if a headset can use the centcom radio channel
+#define RADIO_SPECIAL_CENTCOM (1<<1)
+///Bitflag for if a headset can use the binary radio channel
+#define RADIO_SPECIAL_BINARY (1<<2)

code/__DEFINES/spatial_gridmap.dm

@@ -0,0 +1,55 @@
+/// each cell in a spatial_grid is this many turfs in length and width (with world.max(x or y) being 255, 15 of these fit on each side of a z level)
+#define SPATIAL_GRID_CELLSIZE 17
+/// Takes a coordinate, and spits out the spatial grid index (x or y) it's inside
+#define GET_SPATIAL_INDEX(coord) ROUND_UP((coord) / SPATIAL_GRID_CELLSIZE)
+/// changes the cell_(x or y) vars on /datum/spatial_grid_cell to the x or y coordinate on the map for the LOWER LEFT CORNER of the grid cell.
+/// index is from 1 to SPATIAL_GRID_CELLS_PER_SIDE
+#define GRID_INDEX_TO_COORDS(index) ((((index) - 1) * SPATIAL_GRID_CELLSIZE) + 1)
+/// number of grid cells per x or y side of all z levels. pass in world.maxx or world.maxy
+#define SPATIAL_GRID_CELLS_PER_SIDE(world_bounds) GET_SPATIAL_INDEX(world_bounds)
+
+//grid contents channels
+
+///everything that is hearing sensitive is stored in this channel
+#define SPATIAL_GRID_CONTENTS_TYPE_HEARING RECURSIVE_CONTENTS_HEARING_SENSITIVE
+///every movable that has a client in it is stored in this channel
+#define SPATIAL_GRID_CONTENTS_TYPE_CLIENTS RECURSIVE_CONTENTS_CLIENT_MOBS
+///all atmos machines are stored in this channel (I'm sorry kyler)
+#define SPATIAL_GRID_CONTENTS_TYPE_ATMOS "spatial_grid_contents_type_atmos"
+
+#define ALL_CONTENTS_OF_CELL(cell) (cell.hearing_contents | cell.client_contents | cell.atmos_contents)
+
+///whether movable is itself or containing something which should be in one of the spatial grid channels.
+#define HAS_SPATIAL_GRID_CONTENTS(movable) (movable.spatial_grid_key)
+
+// macros meant specifically to add/remove movables from the internal lists of /datum/spatial_grid_cell,
+// when empty they become references to a single list in SSspatial_grid and when filled they become their own list
+// this is to save memory without making them lazylists as that slows down iteration through them
+#define GRID_CELL_ADD(cell_contents_list, movable_or_list) \
+	if(!length(cell_contents_list)) { \
+		cell_contents_list = list(); \
+		cell_contents_list += movable_or_list; \
+	} else { \
+		cell_contents_list += movable_or_list; \
+	};
+
+#define GRID_CELL_SET(cell_contents_list, movable_or_list) \
+	if(!length(cell_contents_list)) { \
+		cell_contents_list = list(); \
+		cell_contents_list += movable_or_list; \
+	} else { \
+		cell_contents_list |= movable_or_list; \
+	};
+
+//dont use these outside of SSspatial_grid's scope use the procs it has for this purpose
+#define GRID_CELL_REMOVE(cell_contents_list, movable_or_list) \
+	cell_contents_list -= movable_or_list; \
+	if(!length(cell_contents_list)) {\
+		cell_contents_list = dummy_list; \
+	};
+
+///remove from every list
+#define GRID_CELL_REMOVE_ALL(cell, movable) \
+	GRID_CELL_REMOVE(cell.hearing_contents, movable) \
+	GRID_CELL_REMOVE(cell.client_contents, movable) \
+	GRID_CELL_REMOVE(cell.atmos_contents, movable)

code/__DEFINES/subsystems.dm

@@ -137,7 +137,7 @@
 #define INIT_ORDER_INPUT			85
 #define INIT_ORDER_SOUNDS			83
 #define INIT_ORDER_INSTRUMENTS		82
-#define INIT_ORDER_GREYSCALE 81
+#define INIT_ORDER_GREYSCALE		81
 #define INIT_ORDER_VIS				80
 #define INIT_ORDER_SECURITY_LEVEL	79
 #define INIT_ORDER_MATERIALS		76
@@ -149,6 +149,7 @@
 #define INIT_ORDER_TICKER			55
 #define INIT_ORDER_MAPPING			50
 #define INIT_ORDER_EARLY_ASSETS 	48
+#define INIT_ORDER_SPATIAL_GRID		43
 #define INIT_ORDER_ECONOMY			40
 #define INIT_ORDER_OUTPUTS			35
 #define INIT_ORDER_ATOMS			30

code/__HELPERS/_lists.dm

@@ -52,6 +52,10 @@
 #define LAZYINITLIST(L) if (!L) { L = list(); }
 ///If the provided list is empty, set it to null
 #define UNSETEMPTY(L) if (L && !length(L)) L = null
+///If the provided key -> list is empty, remove it from the list
+#define ASSOC_UNSETEMPTY(L, K) if (!length(L[K])) L -= K;
+///Like LAZYCOPY - copies an input list if the list has entries, If it doesn't the assigned list is nulled
+#define LAZYLISTDUPLICATE(L) (L ? L.Copy() : null )
 ///Remove an item from the list, set the list to null if empty
 #define LAZYREMOVE(L, I) if(L) { L -= I; if(!length(L)) { L = null; } }
 ///Add an item to the list, if the list is null it will initialize it