Speedup frequency retrieval for heavy workflows#2305
Open
ShanaryS wants to merge 1 commit intoyomidevs:masterfrom
Open
Speedup frequency retrieval for heavy workflows#2305ShanaryS wants to merge 1 commit intoyomidevs:masterfrom
ShanaryS wants to merge 1 commit intoyomidevs:masterfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3556c05efb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
3556c05 to
e9e4769
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is essentially a follow up to #2251 where batch tokenization was added along with passing some
/termEntriesfields. This is the same forfrequenciesallowing a single batched/tokenizecall to return this information. The benchmarks are the same aslemmatizein the table of the previous PR.The full changes are:
headwordIndexalong with the filtered headwords for/tokenizeTermHeadword.headwordIndexwhich tracks theTermDictionaryEntry.headwordsarray.TermHeadword.indexwas not updated in_removeUnusedHeadwords()unlike theheadwordIndexfor the related arrays such asTermFrequencyTermHeadword.indexsuggest that it's intentional so I didn't consider it a bugTermFrequency.frequencyModewhich exposes the frequency dictionary type so that consumers can process accordinglySummary.titleas the key which may not be sufficient and needs dev inputFindTermsOptions.useAllFrequencyDictionariesso that we can process all frequency dictionaries even insimplemode when the request is through the/tokenizeendpointOutstanding questions are the confirmation if
Summary.titleis sufficient as a cache key.Summary.revisionseems like it should be added but I can't find a good way to get it.Docs: yomidevs/yomitan-api#18