[vibe coded] Add automatic dictionary update toggle (every 24 hours)#2306
Open
bee-san wants to merge 1 commit intoyomidevs:masterfrom
Open
[vibe coded] Add automatic dictionary update toggle (every 24 hours)#2306bee-san wants to merge 1 commit intoyomidevs:masterfrom
bee-san wants to merge 1 commit intoyomidevs:masterfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11d54f1e61
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Adds a global setting to automatically check for and install dictionary updates every 24 hours using chrome.alarms. When enabled, the background script periodically checks each updatable dictionary's indexUrl for new revisions and downloads/imports updates while preserving per-profile dictionary settings. Changes: - Add `alarms` permission to manifest - Add `global.autoUpdateDictionaries` option (schema, types, migration v66) - Add auto-update logic in Backend using chrome.alarms - Add toggle in Dictionaries section of settings UI - Update test expectations for new option version https://claude.ai/code/session_01NBiz14SHokUygVfFjnx3mu
bee-san
force-pushed
the
claude/auto-dict-updates-6Lhkn
branch
from
11d54f1 to
314de8f
Compare
Member
|
I had considered scheduled updates back when the automatic updates were implemented, but decided against it because
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a global setting to automatically check for and install dictionary updates every 24 hours using chrome.alarms. When enabled, the background script periodically checks each updatable dictionary's indexUrl for new revisions and downloads/imports updates while preserving per-profile dictionary settings.
Changes:
alarmspermission to manifestglobal.autoUpdateDictionariesoption (schema, types, migration v66)https://claude.ai/code/session_01NBiz14SHokUygVfFjnx3mu