make processor functions return an array of variants#2312
make processor functions return an array of variants#2312StefanVukovic99 merged 5 commits intoyomidevs:masterfrom
Conversation
StefanVukovic99
added
kind/enhancement
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b99fcdd3e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Kuuuube
left a comment
Kuuuube
left a comment
There was a problem hiding this comment.
I trust that this wont make anything explode.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 650e34ada2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Casheeew
left a comment
Casheeew
left a comment
There was a problem hiding this comment.
maybe needs a bench in the future but for now i trust :gladge:
3 participants
Instead of having a processor return a fixed number of variants defined by its options, this generalizes processors to return an arbitrary array of variants. This enables more flexible use, e.g. adding diacritics to a word where they are missing from some characters but not others, implemented here for Serbo-Croatian.