[it] Support removing apostrophed words in Italian#2318
Open
daxida wants to merge 2 commits intoyomidevs:masterfrom
Open
[it] Support removing apostrophed words in Italian#2318daxida wants to merge 2 commits intoyomidevs:masterfrom
daxida wants to merge 2 commits intoyomidevs:masterfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d248c6707
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Member
|
Codex review about apostrophes seems relevant. That has had to be fixed in some stuff previously. |
Kuuuube
added
kind/enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows a recent discussion in the Discord.
It should allow searching for
Italiawhen hovering overdell'Italia. At the moment, hovering overdell'Italiayields no results. This is done in a different way for French, but since the number of replacements is higher for Italian, a regex made more sense.I named the files X-processors because I based this PR on another one I did for Greek, but I don't know if it should have been transforms or text-preprocessors. Let me know if you want me to change it.
Ran
npm run testand I could see no errors.