Skip to content

Conversation

@eliteprox
Copy link
Collaborator

This release includes the following changes

  • Fix Safari browser compatibility
  • Add combobox support to UI control panel
  • Fix comfystream node preview UI
  • Added missing librosa package to fix ComfyUI-Manager install
  • CI improvements, added tests and linting support

@rickstaa rickstaa requested a review from Copilot March 29, 2025 20:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR releases ComfyStream 0.0.5 with several fixes and enhancements including Safari browser compatibility, combobox support in the control panel, UI preview improvements, and updated CI configurations. Key changes include:

  • Adjusting webcam frameRate options to fix Safari compatibility.
  • Adding enhanced combobox handling in the control panel component.
  • Updating tuple processing in the client and adding CI/test enhancements.

Reviewed Changes

Copilot reviewed 10 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
ui/src/components/webcam.tsx Removed max frameRate to improve Safari compatibility.
ui/src/components/control-panel.tsx Expanded combobox support and input validation improvements.
src/comfystream/client.py Refactored tuple input processing to support combo inputs.
pyproject.toml Bumped version and included missing dependencies.
nodes/web/js/comfystream_ui_preview_node.js Removed redundant resize override for iframe updates.
configs/nodes.yaml Updated branch configuration.
.github/workflows/test.yaml Added CI workflow for testing and linting enhancements.
.github/workflows/comfyui-base.yaml Updated workflow paths with ignore rules for UI directory.
.github/codeql-config.yaml Added a CodeQL config to ignore Docker paths.
Files not reviewed (3)
  • .editorconfig: Language not supported
  • ui/package-lock.json: Language not supported
  • ui/package.json: Language not supported
Comments suppressed due to low confidence (1)

ui/src/components/control-panel.tsx:119

  • Ensure that the recursive call to InputControl for combo cases does not inadvertently cause infinite recursion or unwanted side effects; consider refactoring the combobox options extraction into a helper function.
return InputControl({ input: { ...input, widget: "combo" }, value, onChange });

'max': config.get('max', None),
'widget': config.get('widget', None)
}
if isinstance(value, tuple):
Copy link

Copilot AI Mar 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add explicit handling for tuple inputs with unexpected lengths to prevent silent failures or misconfiguration in input processing.

Copilot uses AI. Check for mistakes.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's track and address later since this is a standard release pr #193

This commit introduces the `comfyui-log-level` and `comfyui-inference-log-level`
arguments to the server, allowing users to adjust the log level and reduce
excessive logging.

Co-authored-by: John | Elite Encoder <[email protected]>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@206900c). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##             main      #192   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         1           
  Lines           ?        55           
  Branches        ?         0           
========================================
  Hits            ?        55           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dependabot bot and others added 12 commits March 31, 2025 22:23
Bumps [next](https://github.com/vercel/next.js) from 15.1.6 to 15.2.4.
- [Release notes](https://github.com/vercel/next.js/releases)
- [Changelog](https://github.com/vercel/next.js/blob/canary/release.js)
- [Commits](vercel/next.js@v15.1.6...v15.2.4)

---
updated-dependencies:
- dependency-name: next
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* set comfystream as default conda env

add ffmpeg6, use conda-forge
dockerfile cleanup
This commit adds the large variant of the Depth Anything V2 model to the
comfystream container.

Co-authored-by: RUFFY-369 <[email protected]>
* added built cv2 from github

* add opencv-cuda install to dockerfile

---------

Co-authored-by: Elite <[email protected]>
* feat: dynamic resolution support

* add dynamic dreamshaper engine build to entrypoint.sh --build-engines

---------
Co-authored-by: ryanontheinstide <[email protected]>
Co-authored-by: Elite <[email protected]>
Copy link
Collaborator

@rickstaa rickstaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eliteprox I did perform tests on this version and everything worked. I however noticed that this contains also changes for v0.0.6. Are you going to ship both changes in v0.0.6?

@rickstaa
Copy link
Collaborator

This release includes the following changes

  • Fix Safari browser compatibility
  • Add combobox support to UI control panel
  • Fix comfystream node preview UI
  • Added missing librosa package to fix ComfyUI-Manager install
  • CI improvements, added tests and linting support

Now has a lot more changes.

@eliteprox
Copy link
Collaborator Author

@eliteprox I did perform tests on this version and everything worked. I however noticed that this contains also changes for v0.0.6. Are you going to ship both changes in v0.0.6?

The idea is to merge stable releases here, so instead of using main, I used a version commit. But for the next version tag I'll have to bring those commits over too in another PR. We can also merge everything periodically

@eliteprox
Copy link
Collaborator Author

eliteprox commented Apr 11, 2025

Once the commits are in here, I'll sync the tags as well

@eliteprox eliteprox merged commit ea8b3b1 into yondonfu:main Apr 11, 2025
eliteprox added a commit that referenced this pull request Apr 11, 2025
eliteprox added a commit that referenced this pull request Apr 11, 2025
eliteprox referenced this pull request in livepeer/comfystream Apr 11, 2025
* ComfyStream Release 0.0.5 (#192)

ComfyStream Release 0.0.5

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Leo Landau <[email protected]>
Co-authored-by: Jason <[email protected]>
Co-authored-by: hjpotter92 <[email protected]>
Co-authored-by: Rick Staa <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: RUFFY-369 <[email protected]>
Co-authored-by: PSchroedl <[email protected]>
Co-authored-by: RyanOnTheInside <[email protected]>
Co-authored-by: Paweł Wilczyński <[email protected]>

* Revert "ComfyStream Release 0.0.5 (#192)" (#210)

This reverts commit ea8b3b1.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Leo Landau <[email protected]>
Co-authored-by: Jason <[email protected]>
Co-authored-by: hjpotter92 <[email protected]>
Co-authored-by: Rick Staa <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: RUFFY-369 <[email protected]>
Co-authored-by: PSchroedl <[email protected]>
Co-authored-by: RyanOnTheInside <[email protected]>
Co-authored-by: Paweł Wilczyński <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants