Skip to content

Commit 9e1d6d5

Browse files
committed
node: topology-mgr: Add logs in the happy path
Signed-off-by: Swati Sehgal <[email protected]>
1 parent def9520 commit 9e1d6d5

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

pkg/kubelet/cm/topologymanager/scope_container.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ limitations under the License.
1717
package topologymanager
1818

1919
import (
20-
"k8s.io/api/core/v1"
20+
"k8s.io/api/core/v1"
2121
"k8s.io/klog/v2"
2222
"k8s.io/kubernetes/pkg/kubelet/cm/admission"
2323
"k8s.io/kubernetes/pkg/kubelet/cm/containermap"
@@ -63,6 +63,7 @@ func (s *containerScope) Admit(pod *v1.Pod) lifecycle.PodAdmitResult {
6363
}
6464

6565
if IsAlignmentGuaranteed(s.policy) {
66+
klog.V(4).InfoS("Resource alignment at container scope guaranteed", "pod", klog.KObj(pod))
6667
metrics.ContainerAlignedComputeResources.WithLabelValues(metrics.AlignScopeContainer, metrics.AlignedNUMANode).Inc()
6768
}
6869
}

pkg/kubelet/cm/topologymanager/scope_pod.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ func (s *podScope) Admit(pod *v1.Pod) lifecycle.PodAdmitResult {
6464
}
6565
if IsAlignmentGuaranteed(s.policy) {
6666
// increment only if we know we allocate aligned resources.
67+
klog.V(4).InfoS("Resource alignment at pod scope guaranteed", "pod", klog.KObj(pod))
6768
metrics.ContainerAlignedComputeResources.WithLabelValues(metrics.AlignScopePod, metrics.AlignedNUMANode).Inc()
6869
}
6970
return admission.GetPodAdmitResult(nil)

pkg/kubelet/cm/topologymanager/topology_manager.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -212,11 +212,13 @@ func (m *manager) RemoveContainer(containerID string) error {
212212
}
213213

214214
func (m *manager) Admit(attrs *lifecycle.PodAdmitAttributes) lifecycle.PodAdmitResult {
215+
klog.V(4).InfoS("Topology manager admission check", "pod", klog.KObj(attrs.Pod))
215216
metrics.TopologyManagerAdmissionRequestsTotal.Inc()
216217

217218
startTime := time.Now()
218219
podAdmitResult := m.scope.Admit(attrs.Pod)
219220
metrics.TopologyManagerAdmissionDuration.Observe(float64(time.Since(startTime).Milliseconds()))
220221

222+
klog.V(4).InfoS("Pod Admit Result", "Message", podAdmitResult.Message, "pod", klog.KObj(attrs.Pod))
221223
return podAdmitResult
222224
}

0 commit comments

Comments
 (0)