Skip to content

Commit be685c8

Browse files
committed
Promote the Job pod failure policy to Conformance
1 parent 5f3316f commit be685c8

File tree

2 files changed

+27
-2
lines changed

2 files changed

+27
-2
lines changed

test/conformance/testdata/conformance.yaml

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1055,6 +1055,29 @@
10551055
pod. Modify the labels of one of the Job's Pods. The Job MUST release the Pod.
10561056
release: v1.16
10571057
file: test/e2e/apps/job.go
1058+
- testname: Ensure pod failure policy allows to ignore failure matching on the DisruptionTarget
1059+
condition
1060+
codename: '[sig-apps] Job should allow to use a pod failure policy to ignore failure
1061+
matching on DisruptionTarget condition [Conformance]'
1062+
description: This test is using an indexed job. The pod corresponding to each index
1063+
creates a marker file on the host and runs 'forever' until evicted. Once the marker
1064+
file is created the pod succeeds seeing it on restart. Thus, we trigger one failure
1065+
per index due to eviction (DisruptionTarget condition is added in the process).
1066+
The Job would be marked as failed, if not for the ignore rule matching on exit
1067+
codes.
1068+
release: v1.32
1069+
file: test/e2e/apps/job.go
1070+
- testname: Ensure pod failure policy allows to ignore failure matching on the exit
1071+
code
1072+
codename: '[sig-apps] Job should allow to use a pod failure policy to ignore failure
1073+
matching on exit code [Conformance]'
1074+
description: This test is using an indexed job. The pod corresponding to each index
1075+
creates a marker file on the host and runs 'forever' until evicted. Once the marker
1076+
file is created the pod succeeds seeing it on restart. Thus, we trigger one failure
1077+
per index due to eviction, so the Job would be marked as failed, if not for the
1078+
ignore rule matching on exit codes.
1079+
release: v1.32
1080+
file: test/e2e/apps/job.go
10581081
- testname: Verify Pod Failure policy allows to fail job early on exit code.
10591082
codename: '[sig-apps] Job should allow to use the pod failure policy on exit code
10601083
to fail the job early [Conformance]'

test/e2e/apps/job.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,14 +143,15 @@ var _ = SIGDescribe("Job", func() {
143143
})
144144

145145
/*
146+
Release: v1.32
146147
Testname: Ensure pod failure policy allows to ignore failure matching on the exit code
147148
Description: This test is using an indexed job. The pod corresponding to each index
148149
creates a marker file on the host and runs 'forever' until evicted. Once
149150
the marker file is created the pod succeeds seeing it on restart. Thus,
150151
we trigger one failure per index due to eviction, so the Job would be
151152
marked as failed, if not for the ignore rule matching on exit codes.
152153
*/
153-
ginkgo.It("should allow to use a pod failure policy to ignore failure matching on exit code", func(ctx context.Context) {
154+
framework.ConformanceIt("should allow to use a pod failure policy to ignore failure matching on exit code", func(ctx context.Context) {
154155
// We set the backoffLimit = numPods-1 so that we can tolerate random
155156
// failures (like OutOfPods from kubelet). Yet, the Job would fail if the
156157
// pod failures were not be ignored.
@@ -217,6 +218,7 @@ var _ = SIGDescribe("Job", func() {
217218
})
218219

219220
/*
221+
Release: v1.32
220222
Testname: Ensure pod failure policy allows to ignore failure matching on the DisruptionTarget condition
221223
Description: This test is using an indexed job. The pod corresponding to each index
222224
creates a marker file on the host and runs 'forever' until evicted. Once
@@ -225,7 +227,7 @@ var _ = SIGDescribe("Job", func() {
225227
condition is added in the process). The Job would be marked as failed,
226228
if not for the ignore rule matching on exit codes.
227229
*/
228-
ginkgo.It("should allow to use a pod failure policy to ignore failure matching on DisruptionTarget condition", func(ctx context.Context) {
230+
framework.ConformanceIt("should allow to use a pod failure policy to ignore failure matching on DisruptionTarget condition", func(ctx context.Context) {
229231
// We set the backoffLimit = numPods-1 so that we can tolerate random
230232
// failures (like OutOfPods from kubelet). Yet, the Job would fail if the
231233
// pod failures were not be ignored.

0 commit comments

Comments
 (0)