Move Client.Watch inside Client.Attach#803
Merged
hackerwins merged 5 commits intomainfrom Apr 16, 2024
Merged
Conversation
--------- Co-authored-by: karockai <karockai@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #803 +/- ##
==========================================
+ Coverage 50.71% 50.81% +0.09%
==========================================
Files 70 70
Lines 10213 10255 +42
==========================================
+ Hits 5180 5211 +31
- Misses 4512 4516 +4
- Partials 521 528 +7 ☔ View full report in Codecov by Sentry. |
krapie
force-pushed
the
hide_watch_in_attach_in_client
branch
2 times, most recently
from
5ab07b5 to
1fe58eb
Compare
krapie
force-pushed
the
hide_watch_in_attach_in_client
branch
from
1fe58eb to
7b2dd71
Compare
Member
|
Thank you for your contribution. In JS SDK, there is also a setting for SyncMode as shown in the link below. How about applying them together? |
Member
Author
|
Is the syncMode feature big? Like I mentioned, I want to keep this PR small. |
hackerwins
requested changes
Apr 15, 2024
Member
hackerwins
left a comment
hackerwins
left a comment
There was a problem hiding this comment.
Thanks for your contribution. 🙏
I left simple questions.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Move
Client.Watch()insideClient.Attach()to hide it from external interface.This PR also introduces
Client.Subscribe()which performs similar functionality with other SDKs.This PR is recreated from #593
Which issue(s) this PR fixes:
Address #584
Special notes for your reviewer:
I prefer keeping this PR size as small as possible to wrap up this task on time.
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: