Skip to content

Modify SNS share button in each post.#101

Open
tetsuyainfra wants to merge 1 commit intoyoshiharuyamashita:masterfrom
tetsuyainfra:modify_share
Open

Modify SNS share button in each post.#101
tetsuyainfra wants to merge 1 commit intoyoshiharuyamashita:masterfrom
tetsuyainfra:modify_share

Conversation

@tetsuyainfra
Copy link
Copy Markdown
Contributor

modify SNS share button at layouts/partials/share.html

@warlord500
Copy link
Copy Markdown

I would really like this to be updated the icons dont show up otherwise

@dcwangmit01
Copy link
Copy Markdown

I've tested this PR. It works and fixes the icon problem.

@motal
Copy link
Copy Markdown

motal commented Nov 22, 2020

I think it's not applied yet.
Would you confirm it?

@Tristor
Copy link
Copy Markdown
Contributor

Tristor commented Feb 5, 2021

Just wanted to update that this PR fixed my icon problem and I've been using it on my site in production for awhile.

@Tristor
Copy link
Copy Markdown
Contributor

Tristor commented Feb 8, 2021

I duplicated this change in PR #110, rebased onto the then current master to resolve merge conflicts, and it has now been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants