Modify SNS share button in each post.#101
Open
tetsuyainfra wants to merge 1 commit intoyoshiharuyamashita:masterfrom
Open
Modify SNS share button in each post.#101tetsuyainfra wants to merge 1 commit intoyoshiharuyamashita:masterfrom
tetsuyainfra wants to merge 1 commit intoyoshiharuyamashita:masterfrom
Conversation
|
I would really like this to be updated the icons dont show up otherwise |
|
I've tested this PR. It works and fixes the icon problem. |
|
I think it's not applied yet. |
Contributor
|
Just wanted to update that this PR fixed my icon problem and I've been using it on my site in production for awhile. |
Contributor
|
I duplicated this change in PR #110, rebased onto the then current master to resolve merge conflicts, and it has now been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modify SNS share button at layouts/partials/share.html