Skip to content

fix: error for large sample sizes in Multinomial NB #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yoshoku merged 1 commit into from
Oct 21, 2025
Merged

fix: error for large sample sizes in Multinomial NB #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rumale-naive_bayes/lib/rumale/naive_bayes/multinomial_nb.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@ def decision_function(x)
x = ::Rumale::Validation.check_convert_sample_array(x)

n_classes = @classes.size
bin_x = x.gt(0)
bin_x = Numo::DFloat.cast(x.gt(0))
log_likelihoods = Array.new(n_classes) do |l|
Math.log(@class_priors[l]) + (Numo::DFloat[*bin_x] * Numo::NMath.log(@feature_probs[l, true])).sum(axis: 1)
Math.log(@class_priors[l]) + (bin_x * Numo::NMath.log(@feature_probs[l, true])).sum(axis: 1)
end
Numo::DFloat[*log_likelihoods].transpose.dup
end
Expand Down
12 changes: 12 additions & 0 deletions rumale-naive_bayes/spec/rumale/naive_bayes/multinomial_nb_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,16 @@
expect(probs.shape[1]).to eq(n_classes)
expect(predicted_by_probs).to eq(y)
end

context 'with large sample sizes' do
let(:x) { Numo::DFloat.new(1_000_000, 4).rand }
let(:y) { Numo::Int32.new(1_000_000).rand(-1, 1) }

it 'does not raise SystemStackError', :aggregate_failures do
expect do
estimator
score
end.not_to raise_error
end
end
end