Only allow canonical names when deserializing Capability#321
Open
stepancheg wants to merge 1 commit intoyouki-dev:mainfrom
Open
Only allow canonical names when deserializing Capability#321stepancheg wants to merge 1 commit intoyouki-dev:mainfrom
stepancheg wants to merge 1 commit intoyouki-dev:mainfrom
Conversation
Signed-off-by: Stepan Koltsov <stepan.koltsov@gmail.com>
stepancheg
force-pushed
the
deserialize-capability
branch
from
8c84b54 to
e7b49a0
Compare
Member
That's right. |
utam0k
approved these changes
Mar 10, 2026
Member
utam0k
left a comment
utam0k
left a comment
There was a problem hiding this comment.
LGTM but waiting for @saschagrunert's review because he introduced this logic in this PR #27.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind design
What this PR does / why we need it:
OCI spec, states:
So I believe deserializing
Capabilityshould not accept strings likesys_AdminforCAP_SYS_ADMIN.If custom deserializer for capability is needed, it does not have to be a part of this crate.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?