builder: Replace derive_builder with bon to drop pervasive unwrap()#326
Open
cgwalters wants to merge 1 commit intoyouki-dev:mainfrom
Open
builder: Replace derive_builder with bon to drop pervasive unwrap()#326cgwalters wants to merge 1 commit intoyouki-dev:mainfrom
cgwalters wants to merge 1 commit intoyouki-dev:mainfrom
Conversation
derive_builder is very popular, but a key selling point of bon is its usage of typestate to ensure that all required fields are provided. Using this crate before this change required pretty pervasive usage of `unwrap()` unnecessarily (or `?` in places that otherwise wouldn't need a `Result`), now with bon it doesn't. Since this crate is regularly bumping semver anyways, let's make doing so valuable. Closes: youki-dev#242 Assisted-by: OpenCode (Claude claude-opus-4-6) Signed-off-by: Colin Walters <walters@verbum.org>
Member
|
It seems CI failed. Could you check it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
derive_builder is very popular, but a key selling point of bon is its usage of typestate to ensure that all required fields are provided.
Using this crate before this change required pretty pervasive usage of
unwrap()unnecessarily (or?in places that otherwise wouldn't need aResult), now with bon it doesn't.Since this crate is regularly bumping semver anyways, let's make doing so valuable.
Closes: #242
Assisted-by: OpenCode (Claude claude-opus-4-6)
/kind api-change