ci: install CRIU in containerd integration tests and skip checkpoint tests#3475
Merged
saku3 merged 1 commit intoyouki-dev:mainfrom Apr 1, 2026
Merged
Conversation
4 tasks
saku3
reviewed
Mar 31, 2026
.github/workflows/e2e.yaml
Outdated
| runc --version | ||
| - name: Integration Test | ||
| run: sudo make RUNC_FLAVOR=crun TEST_RUNTIME=io.containerd.runc.v2 TESTFLAGS="-timeout 40m" integration | ||
| run: sudo make RUNC_FLAVOR=crun TEST_RUNTIME=io.containerd.runc.v2 TESTFLAGS="-timeout 40m -skip TestCheckpoint" integration |
Member
There was a problem hiding this comment.
For tests that youki does not yet support, add explicit -skip entries with comments explaining why they are excluded
You mentioned that in the issue, but does that mean it does not need to be commented on here?
Contributor
Author
There was a problem hiding this comment.
You're right, I missed mentioning that here, so I'll add it now. Thank you for pointing it out!
Add CRIU PPA and install criu package before running containerd integration tests. Skip checkpoint/restore related tests since youki does not yet support that functionality (see issue youki-dev#142). Signed-off-by: nayuta723 <nayuta723@gmail.com>
nayuta723
force-pushed
the
ci/containerd-test-install-criu
branch
from
42250b7 to
3bfa6b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the containerd integration test job, some tests were being silently skipped because CRIU was not installed in the CI environment. Silent skips are easy to overlook and can lead to reduced test coverage going unnoticed.
This PR makes the skipping explicit: install CRIU via
ppa:criu/ppaso it is available in the environment, and add-skip TestCheckpointtoTESTFLAGSso that the checkpoint/restore tests — which happen to require a CRIU-compatible kernel configuration not present in CI — are visibly excluded rather than silently dropped.Type of Change
Testing
Related Issues
Related to #3476
Additional Context
The
-skipflag is available from Go 1.20+; this job uses Go1.20.12.