[FEATURE]: consolidate validate functions from utils into validator.rs - #3661
Open
tommady wants to merge 8 commits into
Open
[FEATURE]: consolidate validate functions from utils into validator.rs#3661tommady wants to merge 8 commits into
tommady wants to merge 8 commits into
Conversation
Signed-off-by: tommady <tommady@users.noreply.github.com>
Signed-off-by: tommady <tommady@users.noreply.github.com>
Signed-off-by: tommady <tommady@users.noreply.github.com>
Signed-off-by: tommady <tommady@users.noreply.github.com>
tommady
marked this pull request as ready for review
August 3, 2026 09:48
Collaborator
Author
|
hi @nayuta723 |
nayuta723
requested changes
Aug 9, 2026
nayuta723
left a comment
nayuta723
left a comment
Contributor
There was a problem hiding this comment.
I left some comments, Please take a look
Signed-off-by: tommady <tommady@users.noreply.github.com>
nayuta723
reviewed
Aug 22, 2026
| mount.destination() | ||
| ); | ||
| }); | ||
| Ok(()) |
Contributor
There was a problem hiding this comment.
mounts
.iter()
.filter(|mount| !mount.destination().is_absolute())
.for_each(|mount| {
tracing::warn!(
"mount destination {:?} is not absolute. \
Relative paths are deprecated in OCI Runtime Spec and may not be supported in future versions. \
The path will be interpreted as relative to '/'.",
mount.destination()
);
});
Contributor
There was a problem hiding this comment.
Is there any reason why this change cannot be implemented?
Signed-off-by: tommady <tommady@users.noreply.github.com>
Signed-off-by: tommady <tommady@users.noreply.github.com>
Collaborator
Author
|
Hi @nayuta723 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Testing
Related Issues
Fixes #3636
Additional Context