test(rootfs): Add adjust_root_mount_propagation unit tests - #3710
Open
Scanf-s wants to merge 3 commits into
Open
test(rootfs): Add adjust_root_mount_propagation unit tests#3710Scanf-s wants to merge 3 commits into
Scanf-s wants to merge 3 commits into
Conversation
Scanf-s
changed the title
Scanf-s
force-pushed
the
test/adjust-root-mount-propagation-unit-test
branch
from
August 28, 2026 15:33
2f403cd to
3bdb9dc
Compare
saku3
reviewed
Sep 5, 2026
| use crate::syscall::test::{MountArgs, TestHelperSyscall}; | ||
|
|
||
| #[test] | ||
| fn test_shared_root_mount_propagation() -> Result<()> { |
Member
There was a problem hiding this comment.
The checks for private, unbindable, and slave are almost identical. Could we extract the common logic into a helper function so that adding tests for other options will be easier in the future?
Contributor
Author
There was a problem hiding this comment.
I agree 👍.
I'll refactor the common logic into a helper function within the test module and keep each test case separate and simple.
I hope this could make it easier to add tests for other propagation options in the future
Signed-off-by: Scanf-s <sullung2yo@gmail.com>
…t test Signed-off-by: Scanf-s <sullung2yo@gmail.com>
Signed-off-by: Scanf-s <sullung2yo@gmail.com>
Scanf-s
force-pushed
the
test/adjust-root-mount-propagation-unit-test
branch
from
September 5, 2026 15:34
420f16e to
d84b1c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
libcontainer/src/rootfs/rootfs.rs.Type of Change
Testing
Related Issues
Refers to #279
Additional Context