Add page margins and social icons in footer#24
Open
bradthornborrow wants to merge 1 commit intoyous:masterfrom
bradthornborrow:feature/social-icons
Open
Add page margins and social icons in footer#24bradthornborrow wants to merge 1 commit intoyous:masterfrom bradthornborrow:feature/social-icons
bradthornborrow wants to merge 1 commit intoyous:masterfrom
bradthornborrow:feature/social-icons
Conversation
yous
reviewed
May 8, 2019
Owner
yous
left a comment
yous
left a comment
There was a problem hiding this comment.
Sorry for the late response, and thanks for the contribution! Only few comments.
| author: Yous | ||
| description: Minimal, responsive Jekyll theme for hackers. | ||
| baseurl: "/whiteglass" # the subpath of your site, e.g. /blog | ||
| baseurl: "/" # the subpath of your site, e.g. /blog |
Owner
There was a problem hiding this comment.
This is for the demo site of this theme, so please revert the change.
| @@ -1,2 +1,3 @@ | |||
| <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin> | |||
| <link href="https://fonts.googleapis.com/css?family=Bitter:400,400i,700" rel="stylesheet"> | |||
| <script src="https://use.fontawesome.com/releases/v5.0.12/js/all.js"></script> No newline at end of file | |||
Owner
There was a problem hiding this comment.
I think this can be included only when site.footer_links exists. Also the script has been updated:
Suggested change
| <script src="https://use.fontawesome.com/releases/v5.0.12/js/all.js"></script> | |
| {% if site.footer_links %}<script defer src="https://use.fontawesome.com/releases/v5.8.2/js/all.js" integrity="sha384-DJ25uNYET2XCl5ZF++U8eNxPWqcKohUUBUpKGlNLMchM7q4Wjg2CUpjHLaL8yYPH" crossorigin="anonymous"></script>{% endif %} |
| <title>{{ title }}</title> | ||
|
|
||
| <title> | ||
| {% if page.title == "Home" %} |
Owner
There was a problem hiding this comment.
The index.html doesn't have page.title. So the logic would be:
<title>
{% if page.title %}
{{ page.title | escape }} · {{ site.title | escape }}
{% else %}
{{ site.title | escape }}
{% endif %}
</title>| */ | ||
| .site-header { | ||
| min-height: 56px; | ||
| border-bottom: 1px solid #eee; |
Owner
There was a problem hiding this comment.
Sorry, but I removed the borders intentionally.
| */ | ||
| .site-footer { | ||
| padding: $spacing-unit 0; | ||
| padding: 15px 0 30px; |
Owner
There was a problem hiding this comment.
I think the padding looks okay when the pagination is enabled.
| } | ||
|
|
||
|
|
||
|
|
| .social-icon { | ||
| display: inline-block; | ||
| padding: 0 0.25em; | ||
|
|
| font-size: 15px; | ||
| color: $grey-color; | ||
| text-align: center; | ||
| border-top: 1px solid #eee; |
| .DS_Store | ||
| .bundle | ||
| .sass-cache | ||
| _sass |
Owner
There was a problem hiding this comment.
The repository has _sass directory for the theme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature update includes the following:
Before accepting any of these changes, you can see them in action on my personal blog at https://thedeskofbrad.ca
Thanks for the great template.