Add a github action for checking binary size on evergreen-arm platforms#7244
Add a github action for checking binary size on evergreen-arm platforms#7244niranjanyardi wants to merge 15 commits intoyoutube:mainfrom
Conversation
19bad25 to
61a33b8
Compare
|
@isarkis mentioned that it might be better to have the build action run this additonal step instead of having an additional action which requires downloading the output of the github build artifacts . What do you think @kaidokert ? |
| } | ||
| } | ||
|
|
||
| if (use_evergreen) { |
There was a problem hiding this comment.
Wouldn't you want to do this for modular builds as well as a ground truth / reference ? E.g. sometimes Evergreen builds grow for Evergreen specific features. Modular builds would represent more as to what goes into the lib.
There was a problem hiding this comment.
no harm in adding , i just added it to the minimum number of platforms i thought will be useful- evergreen-arm.
ill add it for linux-modular as well
talked offline, we are creating a spearate job. this should eventually scale to more metrics on the chrome perf dashboard: https://chromium.googlesource.com/chromium/src/+/HEAD/tools/binary_size/README.md#resource_sizes_py |
61a33b8 to
9b388e2
Compare
9b388e2 to
9339867
Compare
e0ea4c4 to
481646a
Compare
b1eee0e to
a16e455
Compare
4d17b09 to
f0f5fc0
Compare
17ee7c7 to
eee96eb
Compare
eee96eb to
44a62a9
Compare
Issue: 441531382
Add a github action to the evergreen-rdk workflow to check binary size regressions