Skip to content

Add a github action for checking binary size on evergreen-arm platforms#7244

Draft
niranjanyardi wants to merge 15 commits intoyoutube:mainfrom
niranjanyardi:add_github_action_to_check_metrics
Draft

Add a github action for checking binary size on evergreen-arm platforms#7244
niranjanyardi wants to merge 15 commits intoyoutube:mainfrom
niranjanyardi:add_github_action_to_check_metrics

Conversation

@niranjanyardi
Copy link
Contributor

Issue: 441531382

Add a github action to the evergreen-rdk workflow to check binary size regressions

@niranjanyardi niranjanyardi requested a review from a team as a code owner September 19, 2025 23:51
@niranjanyardi niranjanyardi marked this pull request as draft September 19, 2025 23:57
@niranjanyardi niranjanyardi removed the request for review from andrewsavage1 September 19, 2025 23:59
@niranjanyardi niranjanyardi changed the title Add a github action for checking binary size Add a github action for checking binary size on evergreen-arm platforms Sep 20, 2025
@niranjanyardi niranjanyardi force-pushed the add_github_action_to_check_metrics branch 8 times, most recently from 19bad25 to 61a33b8 Compare September 22, 2025 21:16
@niranjanyardi
Copy link
Contributor Author

@isarkis mentioned that it might be better to have the build action run this additonal step instead of having an additional action which requires downloading the output of the github build artifacts .

What do you think @kaidokert ?

}
}

if (use_evergreen) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't you want to do this for modular builds as well as a ground truth / reference ? E.g. sometimes Evergreen builds grow for Evergreen specific features. Modular builds would represent more as to what goes into the lib.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no harm in adding , i just added it to the minimum number of platforms i thought will be useful- evergreen-arm.
ill add it for linux-modular as well

@niranjanyardi
Copy link
Contributor Author

@isarkis mentioned that it might be better to have the build action run this additonal step instead of having an additional action which requires downloading the output of the github build artifacts .

What do you think @kaidokert ?

talked offline, we are creating a spearate job. this should eventually scale to more metrics on the chrome perf dashboard: https://chromium.googlesource.com/chromium/src/+/HEAD/tools/binary_size/README.md#resource_sizes_py

@niranjanyardi niranjanyardi force-pushed the add_github_action_to_check_metrics branch from 61a33b8 to 9b388e2 Compare September 22, 2025 23:52
@niranjanyardi niranjanyardi force-pushed the add_github_action_to_check_metrics branch from 9b388e2 to 9339867 Compare September 23, 2025 00:31
@niranjanyardi niranjanyardi added the runtest Trigger presubmit workflows label Sep 23, 2025
@niranjanyardi niranjanyardi force-pushed the add_github_action_to_check_metrics branch 3 times, most recently from e0ea4c4 to 481646a Compare September 26, 2025 22:37
@niranjanyardi niranjanyardi force-pushed the add_github_action_to_check_metrics branch 3 times, most recently from b1eee0e to a16e455 Compare October 17, 2025 20:34
@niranjanyardi niranjanyardi force-pushed the add_github_action_to_check_metrics branch from 4d17b09 to f0f5fc0 Compare October 17, 2025 22:26
@niranjanyardi niranjanyardi force-pushed the add_github_action_to_check_metrics branch 2 times, most recently from 17ee7c7 to eee96eb Compare October 23, 2025 03:57
@niranjanyardi niranjanyardi force-pushed the add_github_action_to_check_metrics branch from eee96eb to 44a62a9 Compare October 23, 2025 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

runtest Trigger presubmit workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants