Prepend starboard OS name in user-agent string#8706
Open
santoshmahto7 wants to merge 1 commit intoyoutube:26.eapfrom
Open
Prepend starboard OS name in user-agent string#8706santoshmahto7 wants to merge 1 commit intoyoutube:26.eapfrom
santoshmahto7 wants to merge 1 commit intoyoutube:26.eapfrom
Conversation
Contributor
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
jellefoks
requested changes
Jan 16, 2026
cf9aae3 to
bdf9580
Compare
bdf9580 to
cef9874
Compare
yell0wd0g
reviewed
Jan 21, 2026
c5531f5 to
e6396c0
Compare
jellefoks
requested changes
Jan 29, 2026
e6396c0 to
772cf2e
Compare
772cf2e to
b9534a1
Compare
fayev-g
approved these changes
Feb 10, 2026
Contributor
fayev-g
left a comment
There was a problem hiding this comment.
lgtm, as tvOS will be addressed with b/483228604
niranjanyardi
approved these changes
Feb 11, 2026
haozheng-cobalt
approved these changes
Feb 11, 2026
a70a038 to
1bdecce
Compare
|
|
||
| #if BUILDFLAG(IS_ANDROID) || BUILDFLAG(IS_IOS_TVOS) | ||
| #if BUILDFLAG(IS_ANDROID) || BUILDFLAG(IS_IOS_TVOS) || | ||
| BUILDFLAG(IS_STARBOARD) |
Contributor
There was a problem hiding this comment.
causes build error:
./../third_party/musl/src/starboard/include -isystem../../third_party/musl/include -isystem../../third_party/musl/arch/x86_64 -isystem../../third_party/musl/arch/generic -femulated-tls -fvisibility-inlines-hidden -c ../../base/system/sys_info_starboard_unittest.cc -o obj/base/base_unittests/sys_info_starboard_unittest.o
../../base/system/sys_info_starboard_unittest.cc:25:55: error: expected value in expression
#if BUILDFLAG(IS_ANDROID) || BUILDFLAG(IS_IOS_TVOS) ||
The current OS name in user-agent string is fetched using chromium code which just return "Linux". This misses the real OS name for starboard platform and result in YTS test failure. So OS name in user-agent string should include the starboard platform OS name. Bug: 475670748 Change-Id: Iead491cc09a5823429cbd378b5c23bf922246493
auto-merge was automatically disabled
February 27, 2026 06:25
Head branch was pushed to by a user without write access
dd7a382 to
4293341
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current OS name in user-agent string is fetched using
chromium code which just return "Linux". This misses the real
OS name for starboard platform and result in YTS test failure.
So OS name in user-agent string should include the starboard platform
OS name.
Bug: 475670748