Skip to content

Prepend starboard OS name in user-agent string#8706

Open
santoshmahto7 wants to merge 1 commit intoyoutube:26.eapfrom
santoshmahto7:santo/26.eap11/user-agent-os1
Open

Prepend starboard OS name in user-agent string#8706
santoshmahto7 wants to merge 1 commit intoyoutube:26.eapfrom
santoshmahto7:santo/26.eap11/user-agent-os1

Conversation

@santoshmahto7
Copy link
Collaborator

The current OS name in user-agent string is fetched using
chromium code which just return "Linux". This misses the real
OS name for starboard platform and result in YTS test failure.
So OS name in user-agent string should include the starboard platform
OS name.

Bug: 475670748

@santoshmahto7 santoshmahto7 requested a review from a team as a code owner January 16, 2026 08:20
@github-actions
Copy link
Contributor

🤖 Gemini Suggested Commit Message


starboard: Prepend OS name to user-agent string

The user-agent string previously used base::SysInfo::OperatingSystemName(),
which reports "Linux" for Starboard platforms. This generic identification
was insufficient and led to YTS test failures that rely on specific OS
identification. Prepend the Starboard platform's friendly name to the OS
string to provide accurate platform information.

Bug: 475670748

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

@santoshmahto7 santoshmahto7 force-pushed the santo/26.eap11/user-agent-os1 branch from cf9aae3 to bdf9580 Compare January 20, 2026 05:56
@santoshmahto7 santoshmahto7 requested a review from a team as a code owner January 20, 2026 05:56
@santoshmahto7 santoshmahto7 force-pushed the santo/26.eap11/user-agent-os1 branch from bdf9580 to cef9874 Compare January 20, 2026 05:59
@santoshmahto7 santoshmahto7 force-pushed the santo/26.eap11/user-agent-os1 branch from c5531f5 to e6396c0 Compare January 21, 2026 04:38
@santoshmahto7 santoshmahto7 self-assigned this Jan 21, 2026
@jellefoks jellefoks requested a review from fayev-g January 29, 2026 18:29
@niranjanyardi niranjanyardi force-pushed the santo/26.eap11/user-agent-os1 branch from e6396c0 to 772cf2e Compare January 30, 2026 01:30
@santoshmahto7 santoshmahto7 force-pushed the santo/26.eap11/user-agent-os1 branch from 772cf2e to b9534a1 Compare February 3, 2026 14:31
Copy link
Contributor

@fayev-g fayev-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, as tvOS will be addressed with b/483228604

Copy link
Member

@jellefoks jellefoks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@santoshmahto7 santoshmahto7 added the cp-main Cherry pick TO main branch label Feb 11, 2026
@niranjanyardi niranjanyardi requested review from a team and removed request for johnxwork February 11, 2026 19:05
@niranjanyardi niranjanyardi force-pushed the santo/26.eap11/user-agent-os1 branch from a70a038 to 1bdecce Compare February 11, 2026 19:33
@niranjanyardi niranjanyardi enabled auto-merge (squash) February 11, 2026 19:33

#if BUILDFLAG(IS_ANDROID) || BUILDFLAG(IS_IOS_TVOS)
#if BUILDFLAG(IS_ANDROID) || BUILDFLAG(IS_IOS_TVOS) ||
BUILDFLAG(IS_STARBOARD)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

causes build error:

./../third_party/musl/src/starboard/include -isystem../../third_party/musl/include -isystem../../third_party/musl/arch/x86_64 -isystem../../third_party/musl/arch/generic -femulated-tls -fvisibility-inlines-hidden -c ../../base/system/sys_info_starboard_unittest.cc -o obj/base/base_unittests/sys_info_starboard_unittest.o
../../base/system/sys_info_starboard_unittest.cc:25:55: error: expected value in expression
#if BUILDFLAG(IS_ANDROID) || BUILDFLAG(IS_IOS_TVOS) ||

The current OS name in user-agent string is fetched using
chromium code which just return "Linux". This misses the real
OS name for starboard platform and result in YTS test failure.
So OS name in user-agent string should include the starboard platform
OS name.

Bug: 475670748
Change-Id: Iead491cc09a5823429cbd378b5c23bf922246493
auto-merge was automatically disabled February 27, 2026 06:25

Head branch was pushed to by a user without write access

@santoshmahto7 santoshmahto7 force-pushed the santo/26.eap11/user-agent-os1 branch from dd7a382 to 4293341 Compare February 27, 2026 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cp-main Cherry pick TO main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants