Skip to content

Add smaps tagging for V8 memory allocation#9199

Merged
tasunnn merged 3 commits intoyoutube:25.lts.1+from
tasunnn:smaps_tag
Feb 23, 2026
Merged

Add smaps tagging for V8 memory allocation#9199
tasunnn merged 3 commits intoyoutube:25.lts.1+from
tasunnn:smaps_tag

Conversation

@tasunnn
Copy link
Contributor

@tasunnn tasunnn commented Feb 23, 2026

Add smaps tag for V8 memory allocation

This change utilizes the prctl system call to assign names to anonymous
memory regions allocated by V8 on Linux and Android. This allows for
easier identification of V8-specific memory in /proc/pid/smaps,
improving memory debugging and analysis capabilities.

bug: 485648080

@github-actions
Copy link
Contributor

🤖 Gemini Suggested Commit Message


starboard: Tag V8 memory regions for smaps

This change utilizes the prctl system call to assign names to anonymous
memory regions allocated by V8 on Linux and Android. This allows for
easier identification of V8-specific memory in /proc/pid/smaps,
improving memory debugging and analysis capabilities.

Bug: 485648080

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

@tasunnn tasunnn marked this pull request as ready for review February 23, 2026 20:10
@tasunnn tasunnn requested a review from sherryzy February 23, 2026 20:10
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces changes to v8/src/base/platform/platform-starboard.cc to add smaps v8 tagging. This involves including <sys/prctl.h> and using prctl to set the anonymous name for allocated memory regions on Android and Linux. The changes appear to be correct and follow the intended functionality.

@tasunnn tasunnn changed the title Add smaps v8 tagging Add smaps tagging for V8 memory allocation Feb 23, 2026
@tasunnn tasunnn enabled auto-merge (squash) February 23, 2026 20:54
@tasunnn tasunnn merged commit b836063 into youtube:25.lts.1+ Feb 23, 2026
254 of 255 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants