Add smaps tagging for V8 memory allocation#9199
Merged
tasunnn merged 3 commits intoyoutube:25.lts.1+from Feb 23, 2026
Merged
Conversation
Contributor
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
Contributor
There was a problem hiding this comment.
Code Review
The pull request introduces changes to v8/src/base/platform/platform-starboard.cc to add smaps v8 tagging. This involves including <sys/prctl.h> and using prctl to set the anonymous name for allocated memory regions on Android and Linux. The changes appear to be correct and follow the intended functionality.
sherryzy
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add smaps tag for V8 memory allocation
This change utilizes the prctl system call to assign names to anonymous
memory regions allocated by V8 on Linux and Android. This allows for
easier identification of V8-specific memory in /proc/pid/smaps,
improving memory debugging and analysis capabilities.
bug: 485648080