Skip to content

android: use l1 drm system when secure pipeline is required#9231

Merged
jasonzhangxx merged 1 commit intoyoutube:mainfrom
jasonzhangxx:tunnel-mode-use-wdl1
Feb 25, 2026
Merged

android: use l1 drm system when secure pipeline is required#9231
jasonzhangxx merged 1 commit intoyoutube:mainfrom
jasonzhangxx:tunnel-mode-use-wdl1

Conversation

@jasonzhangxx
Copy link
Contributor

Use widevine l1 instead of l3, which is necessary to create secure pipeline, so that secured MediaCodec can be created properly.

Bug: 485905052

@github-actions
Copy link
Contributor

🤖 Gemini Suggested Commit Message


android: Use Widevine L1 for secure pipeline

This change updates the hardcoded DRM system identifier to
'com.widevine.alpha' when an enforced DRM system is required for
tunnel mode. This switch ensures that Widevine L1 is utilized
instead of L3. Utilizing Widevine L1 is essential for establishing
a secure media pipeline, which in turn allows for the proper
creation of a secured MediaCodec instance on Android devices.

Bug: 485905052

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the Widevine key system to "com.widevine.alpha" to enable the use of L1 DRM and secure pipelines on Android. This is a necessary change for creating a secured MediaCodec. My review includes a suggestion to define this key system string as a constant to improve code maintainability and adhere to the project's style guidelines.

Copy link
Contributor

@kjyoun kjyoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comment

@jasonzhangxx jasonzhangxx added the cp-26.android Cherry Pick to the 26.android branch label Feb 24, 2026
@jasonzhangxx jasonzhangxx merged commit 2f5b465 into youtube:main Feb 25, 2026
467 checks passed
@jasonzhangxx jasonzhangxx deleted the tunnel-mode-use-wdl1 branch February 25, 2026 17:35
@jasonzhangxx jasonzhangxx added cp-26.android Cherry Pick to the 26.android branch and removed cp-26.android Cherry Pick to the 26.android branch labels Feb 25, 2026
cobalt-github-releaser-bot pushed a commit that referenced this pull request Feb 25, 2026
Use widevine l1 instead of l3, which is necessary to create secure
pipeline, so that secured MediaCodec can be created properly.

Bug: 485905052
(cherry picked from commit 2f5b465)
@cobalt-github-releaser-bot
Copy link
Collaborator

Caution

Creating the cherry pick PR failed! Check the log at https://github.com/youtube/cobalt/actions/runs/22408535993 for details.

1 similar comment
@cobalt-github-releaser-bot
Copy link
Collaborator

Caution

Creating the cherry pick PR failed! Check the log at https://github.com/youtube/cobalt/actions/runs/22408535993 for details.

johnxwork pushed a commit that referenced this pull request Feb 25, 2026
… is required (#9251)

Refer to the original PR: #9231

Use widevine l1 instead of l3, which is necessary to create secure
pipeline, so that secured MediaCodec can be created properly.

Bug: 485905052

Co-authored-by: Jason <jasonzh@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cp-26.android Cherry Pick to the 26.android branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants