Open
Conversation
This directory came from C25 and is not used by anything. Most of its contents are either outdated or have more up-to-date counterparts in starboard/tvos with the exception of launcher.py and tvos_launcher.py, which have been moved to starboard/tvos in case they are useful in the future. Bug: 459507205
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the starboard/darwin directory, which is described as being outdated and unused. The changes consist of deleting a large number of files and moving a few launcher scripts to starboard/tvos. This appears to be a beneficial cleanup of legacy code, improving the maintainability of the codebase. I have reviewed the changes and found no issues.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This directory came from C25 and is not used by anything. Most of its contents are either outdated or have more up-to-date counterparts in starboard/tvos with the exception of launcher.py and tvos_launcher.py, which have been moved to starboard/tvos in case they are useful in the future.
Bug: 459507205