Open
Conversation
These files were needed by vpx_video_decoder.*, which were removed in youtube#8336 because they were only used in decode to texture mode. Bug: 459507205 Bug: 447334535
Contributor
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the vpx_loop_filter_manager.cc and vpx_loop_filter_manager.h files. As stated in the description, these files are no longer needed since their dependents, vpx_video_decoder.*, were removed in a previous change. This appears to be a correct and straightforward code cleanup. I have no issues to report.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These files were needed by vpx_video_decoder.*, which were removed in #8336 because they were only used in decode to texture mode.
Bug: 459507205
Bug: 447334535