Skip to content

tvOS: Remove vpx_loop_filter_manager.*#9246

Open
rakuco wants to merge 1 commit intoyoutube:mainfrom
rakuco:tvos/remove-vpx_loop_filter_manager
Open

tvOS: Remove vpx_loop_filter_manager.*#9246
rakuco wants to merge 1 commit intoyoutube:mainfrom
rakuco:tvos/remove-vpx_loop_filter_manager

Conversation

@rakuco
Copy link
Collaborator

@rakuco rakuco commented Feb 25, 2026

These files were needed by vpx_video_decoder.*, which were removed in #8336 because they were only used in decode to texture mode.

Bug: 459507205
Bug: 447334535

These files were needed by vpx_video_decoder.*, which were removed in youtube#8336
because they were only used in decode to texture mode.

Bug: 459507205
Bug: 447334535
@rakuco rakuco requested a review from a team as a code owner February 25, 2026 11:01
@github-actions
Copy link
Contributor

🤖 Gemini Suggested Commit Message


tvos: Remove VPX loop filter manager

The vpx_loop_filter_manager files are no longer required. They were
dependencies of vpx_video_decoder, which was removed in a prior change.
The vpx_video_decoder was exclusively used by the decode-to-texture
mode, which is no longer in use. This change cleans up the obsolete
files from the tvOS media component.

Bug: 459507205
Bug: 447334535

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the vpx_loop_filter_manager.cc and vpx_loop_filter_manager.h files. As stated in the description, these files are no longer needed since their dependents, vpx_video_decoder.*, were removed in a previous change. This appears to be a correct and straightforward code cleanup. I have no issues to report.

@rakuco
Copy link
Collaborator Author

rakuco commented Feb 25, 2026

cc @abhijeetk @jkim-julie @Gyuyoung

@rakuco rakuco requested a review from fayev-g February 25, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant