Open
Conversation
Syncs changes from PR youtube#9029 with the updated VP9 header include paths introduced in PR youtube#8867. This resolves a compilation error in the internal build pipeline. Bug: 460479616 Bug: 487326366
Contributor
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
Collaborator
Author
|
cc : @Gyuyoung @jkim-julie @rakuco |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the include paths for VP9 headers on tvOS to fix a compilation error. The changes in starboard/tvos/shared/BUILD.gn and starboard/tvos/shared/media/av_video_sample_buffer_builder.mm correctly update the file paths and remove the associated TODO comments. The changes are straightforward and appear correct.
rakuco
reviewed
Feb 25, 2026
Collaborator
rakuco
left a comment
rakuco
left a comment
There was a problem hiding this comment.
informal lgtm from my side
as a side note, we should probably drop the uikit/ part from the internal files too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the include and source paths for VP9 hardware accelerated video
sample buffer builder files within the tvOS Starboard component. This
change synchronizes the paths with recent internal submodule directory
structure updates. It resolves a compilation error in the internal
build pipeline by pointing to the correct locations.
This syncs changes from PR #9029 with the updated VP9 header include
paths introduced in PR #8867.
Bug: 460479616
Bug: 487326366