starboard: Remove dead internal private build dependencies#9249
starboard: Remove dead internal private build dependencies#9249abhijeetk wants to merge 1 commit intoyoutube:mainfrom
Conversation
Deletes dead build configuration for stubs, NPLB tests, and BUILD.gn targets. This follows the upstream removal of VirtualReality from Starboard (see: youtube#2740). Bug: 486791051 Bug: 487326366
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
|
cc : @Gyuyoung @jkim-julie @rakuco |
There was a problem hiding this comment.
Code Review
This pull request removes dead code and build configurations related to the deprecated VirtualReality feature. The changes are focused on removing conditional logic for is_internal_build and associated dependencies from several BUILD.gn files. The modifications are straightforward and align with the goal of cleaning up obsolete code. The changes appear correct and I see no issues.
rakuco
left a comment
There was a problem hiding this comment.
The PR title looks confusing to me: this patch is not tvOS-specific, and none of the changes reference VirtualReality specifically. Could you make it more generic?
Done. Update the PR title. |
Delete build configurations for VirtualReality stubs, NPLB tests,
and related BUILD.gn targets. This change removes dead code
following the upstream deprecation and removal of VirtualReality
from the Starboard abstraction layer.(see: #2740).
Bug: 486791051
Bug: 487326366