Skip to content

starboard: Remove dead internal private build dependencies#9249

Open
abhijeetk wants to merge 1 commit intoyoutube:mainfrom
abhijeetk:remove-unwanted-build-configuration
Open

starboard: Remove dead internal private build dependencies#9249
abhijeetk wants to merge 1 commit intoyoutube:mainfrom
abhijeetk:remove-unwanted-build-configuration

Conversation

@abhijeetk
Copy link
Collaborator

@abhijeetk abhijeetk commented Feb 25, 2026

Delete build configurations for VirtualReality stubs, NPLB tests,
and related BUILD.gn targets. This change removes dead code
following the upstream deprecation and removal of VirtualReality
from the Starboard abstraction layer.(see: #2740).

Bug: 486791051
Bug: 487326366

Deletes dead build configuration for stubs, NPLB tests, and BUILD.gn
targets. This follows the upstream removal of VirtualReality from
Starboard (see: youtube#2740).

Bug: 486791051
Bug: 487326366
@github-actions
Copy link
Contributor

🤖 Gemini Suggested Commit Message


tvos: Remove dead VirtualReality build config

Delete build configurations for VirtualReality stubs, NPLB tests,
and related BUILD.gn targets. This change removes dead code
following the upstream deprecation and removal of VirtualReality
from the Starboard abstraction layer.

Bug: 486791051
Bug: 487326366

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

@abhijeetk abhijeetk changed the title tvos: Remove dead VirtualReality build configuration tvos: Remove dead VirtualReality build config Feb 25, 2026
@abhijeetk abhijeetk marked this pull request as ready for review February 25, 2026 12:01
@abhijeetk
Copy link
Collaborator Author

cc : @Gyuyoung @jkim-julie @rakuco

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes dead code and build configurations related to the deprecated VirtualReality feature. The changes are focused on removing conditional logic for is_internal_build and associated dependencies from several BUILD.gn files. The modifications are straightforward and align with the goal of cleaning up obsolete code. The changes appear correct and I see no issues.

Copy link
Collaborator

@rakuco rakuco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title looks confusing to me: this patch is not tvOS-specific, and none of the changes reference VirtualReality specifically. Could you make it more generic?

@abhijeetk abhijeetk changed the title tvos: Remove dead VirtualReality build config starboard: Remove dead internal private build dependencies Feb 25, 2026
@abhijeetk
Copy link
Collaborator Author

The PR title looks confusing to me: this patch is not tvOS-specific, and none of the changes reference VirtualReality specifically. Could you make it more generic?

Done. Update the PR title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants