Clean up commented out gcloud install step.#9253
Merged
SortaCookie merged 1 commit intoyoutube:mainfrom Feb 25, 2026
Merged
Conversation
Contributor
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
This was accidentally left in from youtube#9225. Bug: 432823450
f57a242 to
024a4f8
Compare
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the sccache GitHub Action to conditionally configure cache access. It now supports read-write access when a GCS key is provided, and falls back to read-only access otherwise. The logic is sound, but I've suggested a small refactoring to improve maintainability by removing a duplicated bucket name.
I am having trouble creating individual review comments. Click here to see my feedback.
.github/actions/sccache/action.yaml (18-30)
To improve maintainability and avoid duplicating the bucket name string, consider defining it in a variable at the beginning of the script and reusing it in both the if and else blocks. This will make future updates to the bucket name easier and less error-prone.
BUCKET_NAME="cobalt-sccache-tvos-bucket"
if [[ -n "$SCCACHE_GCS_KEY" ]]; then
# If we have a GCS key we use READ_WRITE
printf "%s" "$SCCACHE_GCS_KEY" > "${HOME}/gcloud.json"
echo "SCCACHE_GCS_KEY_PATH=${HOME}/gcloud.json" >> $GITHUB_ENV
echo "SCCACHE_GCS_RW_MODE=READ_WRITE" >> $GITHUB_ENV
echo "SCCACHE_GCS_BUCKET=${BUCKET_NAME}" >> $GITHUB_ENV
else
# Read only
echo "SCCACHE_BUCKET=${BUCKET_NAME}" >> $GITHUB_ENV
echo "SCCACHE_ENDPOINT=https://storage.googleapis.com" >> $GITHUB_ENV
echo "SCCACHE_S3_NO_CREDENTIALS=true" >> $GITHUB_ENV
echo "SCCACHE_REGION=auto" >> $GITHUB_ENV
fi
oxve
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was accidentally left in from #9225.
Bug: 432823450