Remove #include MACRO

[briantting]

Removes SB_PLAYER_DMP_WRITER_INCLUDE_PATH #include MACRO as the SISO scanner has difficulty uploading required dependenies for remote builds.

Bug: 454374226

[github-actions]

🤖 Gemini Suggested Commit Message

---

build: Remove include macro causing scanner issues

The SB_PLAYER_DMP_WRITER_INCLUDE_PATH preprocessor macro has been
removed. This macro previously defined the include path for
video_dmp_writer.h. Its usage has been updated to directly include
the header file via a string literal.

This change resolves difficulties encountered by the SISO scanner when
uploading required dependencies for remote builds, improving the
build system's compatibility.

Bug: 454374226

---

💡 Pro Tips for a Better Commit Message:

1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
2. Re-run the Generator: Post a comment with: /generate-commit-message

[gemini-code-assist]

Code Review

This pull request removes the SB_PLAYER_DMP_WRITER_INCLUDE_PATH macro, replacing its usage with a hardcoded include path to resolve a build tool issue. While this simplifies the code, it removes a layer of platform-specific configuration. I've raised a concern about the potential for this change to break builds on other platforms that might have been using this macro to provide a different path for the header file.

I am having trouble creating individual review comments. Click here to see my feedback.

starboard/linux/shared/configuration_public.h (48-51)

Removing the SB_PLAYER_DMP_WRITER_INCLUDE_PATH macro and hardcoding the include path in shared code removes the flexibility for platforms to specify a custom path for video_dmp_writer.h. The original comment for this macro (lines 48-49) suggests this flexibility was intentional to support platforms that might not include the video_dmp library in the same way. This change introduces a risk of breaking builds on other platforms that enable SB_PLAYER_ENABLE_VIDEO_DUMPER but require a different path for this header.