Open
Conversation
Enables Siso as a drop-in replacement for Ninja. Sets up Siso backend config via gclient sync and Siso toggles via GN. Deprecates reclient_cfgs. Bug: 454374226
Contributor
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
Contributor
There was a problem hiding this comment.
Code Review
The pull request successfully enables Siso for Cobalt builds by integrating its configuration into the DEPS file and configure_siso.py script, and by creating a dedicated cobalt.star backend configuration. It also correctly deprecates the old reclient_cfgs by removing relevant files and configuration in gn.py. The changes are well-aligned with the pull request description and appear to be functionally correct.
| load("@builtin//struct.star", "module") | ||
|
|
||
| def __platform_properties(ctx): | ||
| container_image = "docker://gcr.io/chops-public-images-prod/rbe/siso-chromium/linux@sha256:ef35d347f4a4a2d32b76fd908e66e96f59bf8ba7379fd5626548244c45343b2b" |
Contributor
There was a problem hiding this comment.
The container_image string is a long, critical configuration value. Extracting it into a named constant would improve readability and make it easier to locate and update if the image SHA256 ever needs to change.
_SISO_CHROMIUM_LINUX_IMAGE = "docker://gcr.io/chops-public-images-prod/rbe/siso-chromium/linux@sha256:ef35d347f4a4a2d32b76fd908e66e96f59bf8ba7379fd5626548244c45343b2b"
container_image = _SISO_CHROMIUM_LINUX_IMAGE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables Siso as a drop-in replacement for Ninja. Sets up Siso backend config via gclient sync and Siso toggles via GN. Deprecates reclient_cfgs.
Bug: 454374226