Skip to content

Enable Siso on builds#9287

Open
briantting wants to merge 1 commit intoyoutube:mainfrom
briantting:main
Open

Enable Siso on builds#9287
briantting wants to merge 1 commit intoyoutube:mainfrom
briantting:main

Conversation

@briantting
Copy link
Contributor

Enables Siso as a drop-in replacement for Ninja. Sets up Siso backend config via gclient sync and Siso toggles via GN. Deprecates reclient_cfgs.

Bug: 454374226

Enables Siso as a drop-in replacement for Ninja. Sets up Siso backend
config via gclient sync and Siso toggles via GN. Deprecates
reclient_cfgs.

Bug: 454374226
@briantting briantting requested review from a team as code owners February 27, 2026 10:20
@briantting briantting requested a review from yell0wd0g February 27, 2026 10:20
@github-actions
Copy link
Contributor

🤖 Gemini Suggested Commit Message


build: Enable Siso as remote execution backend

Enable Siso as a drop-in replacement for Ninja to leverage
remote execution for Cobalt builds.

This change sets up the Siso backend configuration via gclient sync
and toggles its usage via GN arguments when remote execution is
enabled. It also deprecates and removes the legacy reclient
configuration files from cobalt/reclient_cfgs.
Bug: 454374226

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully enables Siso for Cobalt builds by integrating its configuration into the DEPS file and configure_siso.py script, and by creating a dedicated cobalt.star backend configuration. It also correctly deprecates the old reclient_cfgs by removing relevant files and configuration in gn.py. The changes are well-aligned with the pull request description and appear to be functionally correct.

load("@builtin//struct.star", "module")

def __platform_properties(ctx):
container_image = "docker://gcr.io/chops-public-images-prod/rbe/siso-chromium/linux@sha256:ef35d347f4a4a2d32b76fd908e66e96f59bf8ba7379fd5626548244c45343b2b"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The container_image string is a long, critical configuration value. Extracting it into a named constant would improve readability and make it easier to locate and update if the image SHA256 ever needs to change.

    _SISO_CHROMIUM_LINUX_IMAGE = "docker://gcr.io/chops-public-images-prod/rbe/siso-chromium/linux@sha256:ef35d347f4a4a2d32b76fd908e66e96f59bf8ba7379fd5626548244c45343b2b"
    container_image = _SISO_CHROMIUM_LINUX_IMAGE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant