fix: Stroke color in SignInWithYouVersionButton #49
Closed
Kyleasmth wants to merge 4 commits intoyouversion:mainfrom
Closed
fix: Stroke color in SignInWithYouVersionButton #49Kyleasmth wants to merge 4 commits intoyouversion:mainfrom
Kyleasmth wants to merge 4 commits intoyouversion:mainfrom
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Signed-off-by: David Fedor <davidfedor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The "Sign in with YouVersion" button outline was too harsh on iOS. The light mode stroke color was using gray-25 (
#828080), while Kotlin and web use a softer grey. Updated the light mode stroke color to gray-15 (#DDDBDB) to match the other platforms.Type of Change
feat:New feature (non-breaking change which adds functionality)fix:Bug fix (non-breaking change which fixes an issue)docs:Documentation updaterefactor:Code refactoring (no functional changes)perf:Performance improvementtest:Test additions or updatesbuild:Build system or dependency changesci:CI configuration changeschore:Other changes (maintenance, etc.)Breaking Changes
Breaking Change Details:
Migration Guide:
Checklist
Conventional Commits
✅ All commits in this PR follow conventional commit format:
Example commit messages:
feat(api): add Bible verse lookup methodfix(auth): resolve token refresh race conditiondocs: update installation instructionsFor breaking changes:
feat(api)!: redesign Bible content APISee CONTRIBUTING.md for detailed guidelines.
Related Issues
Closes #PE-1328
Relates to #
Additional Context
BEFORE:


AFTER:
Reviewer Notes