Skip to content

fix: Stroke color in SignInWithYouVersionButton #49

Closed
Kyleasmth wants to merge 4 commits intoyouversion:mainfrom
Kyleasmth:ks/YPE-1328-Sign-in-with-YouVersion-button-outline-too-harsh
Closed

fix: Stroke color in SignInWithYouVersionButton #49
Kyleasmth wants to merge 4 commits intoyouversion:mainfrom
Kyleasmth:ks/YPE-1328-Sign-in-with-YouVersion-button-outline-too-harsh

Conversation

@Kyleasmth
Copy link
Copy Markdown
Collaborator

Description

The "Sign in with YouVersion" button outline was too harsh on iOS. The light mode stroke color was using gray-25 (#828080), while Kotlin and web use a softer grey. Updated the light mode stroke color to gray-15 (#DDDBDB) to match the other platforms.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation update
  • refactor: Code refactoring (no functional changes)
  • perf: Performance improvement
  • test: Test additions or updates
  • build: Build system or dependency changes
  • ci: CI configuration changes
  • chore: Other changes (maintenance, etc.)

Breaking Changes

  • This PR contains BREAKING CHANGES

Breaking Change Details:

Migration Guide:

Checklist

  • My code follows the project's code style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • All commit messages follow conventional commits format
  • I have updated the appropriate section in documentation (if needed)

Conventional Commits

All commits in this PR follow conventional commit format:

<type>(<scope>): <subject>

[optional body]

[optional footer]

Example commit messages:

  • feat(api): add Bible verse lookup method
  • fix(auth): resolve token refresh race condition
  • docs: update installation instructions

For breaking changes:

  • feat(api)!: redesign Bible content API

See CONTRIBUTING.md for detailed guidelines.

Related Issues

Closes #PE-1328
Relates to #

Additional Context

BEFORE:
Screenshot 2026-02-19 at 2 15 27 PM
AFTER:
Screenshot 2026-02-19 at 2 15 33 PM

Reviewer Notes

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@Kyleasmth Kyleasmth requested a review from davidfedor February 25, 2026 17:49
Copy link
Copy Markdown
Member

@davidfedor davidfedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Kyleasmth Kyleasmth closed this Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants