Open
Conversation
added 2 commits
January 28, 2019 19:08
DNS-over-HTTPS service.
DNS-over-HTTPS service.
Collaborator
|
I've finally gotten around to review this, and it does not work for me... In your tests, you're not testing the |
Contributor
Author
|
I was thinking how to achieve that but getAnswer would fire an http request and that would not be a unit test anymore. Maybe you have an idea how to improve this test? |
Collaborator
|
Fair point, it is no longer a unit test. But the fact remains that I cannot get the feature to work. I'm not familiar with the API, do you need a key or something? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch adds a new resolver that uses Google's HTTPS service to resolve DNS records user requested. Another example file is provided which shows proof of concept.